Bug 11287

Summary: Windows build bustage
Product: WebKit Reporter: Don Gibson <dgibson77>
Component: WebCore Misc.Assignee: Don Gibson <dgibson77>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch v1
none
build fixer
aroben: review+
build fix 2 aroben: review+

Don Gibson
Reported 2006-10-13 20:04:57 PDT
The windows build is busted again after recent changes by mjs and hyatt. Patch hopefully coming soon.
Attachments
patch v1 (9.11 KB, patch)
2006-10-13 20:22 PDT, Don Gibson 		no flags
DetailsFormatted DiffDiff
build fixer (14.78 KB, patch)
2006-10-16 13:41 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
build fix 2 (14.77 KB, patch)
2006-10-16 13:54 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Gibson
Comment 1 2006-10-13 20:22:46 PDT
Created attachment 11085 [details] patch v1 As noted in the ChangeLog entry, this doesn't completely fix the build, but it gets almost all the way there, so I think it should land. I cannot for the life of me figure out why the link step is still failing.
Sam Weinig
Comment 2 2006-10-16 13:41:22 PDT
Created attachment 11117 [details] build fixer
Adam Roben (:aroben)
Comment 3 2006-10-16 13:48:30 PDT
Comment on attachment 11117 [details] build fixer You've got tabs all over this patch which subversion will choke on r=me
Sam Weinig
Comment 4 2006-10-16 13:54:16 PDT
Created attachment 11118 [details] build fix 2 This time featuring less tabs!
Sam Weinig
Comment 5 2006-10-16 14:05:25 PDT
Landed in r17070.
Adam Roben (:aroben)
Comment 6 2006-10-16 14:15:33 PDT
Comment on attachment 11118 [details] build fix 2 Setting r+ to get this out of the review queue
Note You need to log in before you can comment on or make changes to this bug.