Bug 112848

Summary: dialog-enabled.html and dialog-disabled.html don't really test what they think they do
Product: WebKit Reporter: Thomas Sepez <tsepez>
Component: WebCore Misc.Assignee: Thomas Sepez <tsepez>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112191    
Attachments:
Description Flags
Patch. none

Thomas Sepez
Reported 2013-03-20 14:51:52 PDT
This was kicked loose by the V8 Binding Integrity work. In these tests, there is HTML <dialog id="mydialog"></dialog> before the script that does: if (window.internals) internals.settings.setDialogElementEnabled(true); and thus HTMLElementFactory.cpp's dialogConstructor() returns 0, and an HTMLUnknownElement with name "dialog" is created. To fix the test, we must set the setting before parsing the <dialog> element.
Attachments
Patch. (2.43 KB, patch)
2013-03-20 15:19 PDT, Thomas Sepez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thomas Sepez
Comment 1 2013-03-20 15:19:43 PDT
Created attachment 194132 [details] Patch. Only tests changed.
WebKit Review Bot
Comment 2 2013-03-20 16:07:07 PDT
Comment on attachment 194132 [details] Patch. Clearing flags on attachment: 194132 Committed r146406: <http://trac.webkit.org/changeset/146406>
WebKit Review Bot
Comment 3 2013-03-20 16:07:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.