Bug 112805

Summary: [Qt] Add WOFF support when using zlib
Product: WebKit Reporter: Pierre Rossi <pierre.rossi>
Component: New BugsAssignee: Pierre Rossi <pierre.rossi>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch allan.jensen: review-

Description Pierre Rossi 2013-03-20 06:40:31 PDT 
[Qt] Add WOFF support when using zlib
Comment 1 Pierre Rossi 2013-03-26 12:04:45 PDT 
Created attachment 195134 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-26 12:07:41 PDT 
Attachment 195134 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt-5.0-wk2/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/Target.pri', u'Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp']" exit_code: 1
Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp:80:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Allan Sandfeld Jensen 2013-03-26 15:08:43 PDT 
Comment on attachment 195134 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195134&action=review

> LayoutTests/platform/qt-5.0-wk2/TestExpectations:150
> +# [Qt][WK2] WTR doesn't dump pixels in a way that's consistent with other ports
> +webkit.org/b/113320 fast/css/font-face-woff.html [ Skip ]

As far as I can tell there is no expectations shipped for font-face-woff.html, so you need to add one for Qt. Are you saying Qt has different results between WK1 and WK2?
Comment 4 Pierre Rossi 2013-03-27 03:42:43 PDT 
Created attachment 195263 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-27 03:45:03 PDT 
Attachment 195263 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt-5.0-wk2/TestExpectations', u'LayoutTests/platform/qt/TestExpectations', u'LayoutTests/platform/qt/fast/css/font-face-woff-expected.png', u'LayoutTests/platform/qt/fast/css/font-face-woff-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/Target.pri', u'Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp']" exit_code: 1
Source/WebCore/platform/graphics/qt/FontCustomPlatformDataQt.cpp:80:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Allan Sandfeld Jensen 2013-03-27 09:28:45 PDT 
Comment on attachment 195263 [details]
Patch

The render-tree dump seems to have been generated using --ignore-metrics, and I suspect the image is based on Qt 5.1 since it doesn't have aliased text. 
I think we might be better off without the expectations, than wrong ones. Hopefully we can land new expectations using garden-o-matic afterwards.
Comment 7 Allan Sandfeld Jensen 2013-03-27 09:29:41 PDT 
Comment on attachment 195134 [details]
Patch

On second thought, expectations can be landed later.
Comment 8 WebKit Review Bot 2013-03-27 16:56:04 PDT 
Comment on attachment 195134 [details]
Patch

Clearing flags on attachment: 195134

Committed r147020: <http://trac.webkit.org/changeset/147020>
Comment 9 WebKit Review Bot 2013-03-27 16:56:08 PDT 
All reviewed patches have been landed.  Closing bug.