Bug 112778

Summary: [GTK] Build ANGLE sources into a separate library from libWebCore.la
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2013-03-20 00:26:05 PDT
[GTK] Build ANGLE sources into a separate library from libWebCore.la
Attachments
Patch (5.08 KB, patch)
2013-03-20 00:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (21.18 KB, patch)
2013-03-20 12:39 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (22.49 KB, patch)
2013-03-20 13:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-03-20 00:33:02 PDT
Created attachment 193993 [details] Patch
Martin Robinson
Comment 2 2013-03-20 12:20:44 PDT
Comment on attachment 193993 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193993&action=review > Source/WebCore/GNUmakefile.am:438 > +if ENABLE_WEBGL I'm not sure that WebGL is the right trigger here. Instead it's whether or not OpenGL support is enabled, since GraphicsContext3D is also used by the TextureMapper.
Zan Dobersek
Comment 3 2013-03-20 12:39:45 PDT
Created attachment 194097 [details] Patch
Zan Dobersek
Comment 4 2013-03-20 12:43:47 PDT
(In reply to comment #3) > Created an attachment (id=194097) [details] > Patch Unconditionally adding the build targets to libANGLE.la, they don't get built if the OpenGL accelerated backend isn't used (much like libLevelDB.la). Clutter implementations of DrawingBuffer, GraphicsContext3D and GraphicsContext3DPrivate classes are used when Clutter is used as the accelerated backend, Cairo implementations are used otherwise. All files should have the appropriate feature guards so it shouldn't be a problem including them in build when WebGL is disabled.
Martin Robinson
Comment 5 2013-03-20 12:46:05 PDT
Comment on attachment 194097 [details] Patch One final request before landing. Do you mind moving the ANGLE build to Source/ThirdParty/ANGLE/GNUmakefile.am? I don't mean to be annoying, but as long as you are fixing one of my mistakes, you might consider fixing another. :)
Zan Dobersek
Comment 6 2013-03-20 13:03:35 PDT
Created attachment 194101 [details] Patch
Zan Dobersek
Comment 7 2013-03-20 13:04:14 PDT
(In reply to comment #6) > Created an attachment (id=194101) [details] > Patch Pretty much this, no? I'll run another build to double-check and then land it.
Martin Robinson
Comment 8 2013-03-20 14:11:29 PDT
Comment on attachment 194101 [details] Patch Looks great to me!
Zan Dobersek
Comment 9 2013-03-20 14:28:21 PDT
Comment on attachment 194101 [details] Patch Clearing flags on attachment: 194101 Committed r146390: <http://trac.webkit.org/changeset/146390>
Zan Dobersek
Comment 10 2013-03-20 14:28:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.