Bug 112760 – do not use string reference for enum support in CodeGeneratorJS.pm

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[arno.]

Hi,
as discussed in bug #112475 comment 13, this is about not using String reference in generated binding for enum values.

[arno.]

Created attachment 193958 [details]
patch proposal

[Kentaro Hara]

Comment on attachment 193958 [details]
patch proposal

Thanks for the quick fix.

[WebKit Review Bot]

Comment on attachment 193958 [details]
patch proposal

Clearing flags on attachment: 193958

Committed r146292: <http://trac.webkit.org/changeset/146292>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 193958 [details]
patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=193958&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2147
> +                                    push(@implContent, "    const String string = value.isEmpty() ? String() : value.toString(exec)->value(exec);\n");

Not sure why the const is here. It’s OK, but unneeded.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2789
> +            push(@$outputArray, "    const String ${name}(${argValue}.isEmpty() ? String() : ${argValue}.toString(exec)->value(exec));\n");

Ditto.