Bug 112758

Summary:

[V8] Simplify implementation of EnforceRange conversions

Product:

WebKit

Reporter:

Michael Pruett <michael>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, haraken, japhet, jsbell, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Michael Pruett

Reported 2013-03-19 17:40:10 PDT

The implementation of EnforceRange in conversion functions in V8Bindings.cpp involves some repetition which could be refactored into a common helper method. Furthermore the formula for rounding to the nearest integer not greater in absolute value can be stated in a more concise manner.

Attachments
Patch (4.95 KB, patch) 2013-03-19 20:52 PDT, Michael Pruett	no flags	Details Formatted Diff Diff
Patch (4.95 KB, patch) 2013-03-19 21:14 PDT, Michael Pruett	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Michael Pruett

Comment 1 2013-03-19 17:51:11 PDT

Rounding to the nearest integer not greater in absolute value, currently accomplished using the following formula in V8Binding.cpp: x = (x < 0 ? -1 : 1) * floor(fabs(x)) can be expressed more succinctly: x = trunc(x)

Michael Pruett

Comment 2 2013-03-19 20:52:51 PDT

Created attachment 193977 [details] Patch

Joshua Bell

Comment 3 2013-03-19 21:04:05 PDT

Nice, thanks for the cleanup.

Michael Pruett

Comment 4 2013-03-19 21:14:24 PDT

Created attachment 193979 [details] Patch

Kentaro Hara

Comment 5 2013-03-19 21:15:04 PDT

Comment on attachment 193979 [details] Patch Great.