This bug likely occurs because line-heights are truncated to integers (see m_lineHeight in RenderBlock) but boxes use sub-pixel values. This is a bug, but I don't intend to tackle this soon. I'll fix this one. Making m_lineHeight a LayoutUnit did not fix this bug, so I think there's something else going on here. (In reply to comment #3) > Making m_lineHeight a LayoutUnit did not fix this bug, so I think there's something else going on here. I think FloatIntervalSearchAdapter needs to be converted to LayoutUnit too. Created attachment 195742 [details]
Patch
Comment on attachment 195742 [details] Patch Attachment 195742 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17296843 Comment on attachment 195742 [details] Patch Attachment 195742 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17357504 New failing tests: fast/multicol/vertical-rl/float-multicol.html Created attachment 195753 [details]
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 195742 [details] Patch Attachment 195742 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17354555 New failing tests: fast/backgrounds/background-position-parsing.html Created attachment 195755 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 195846 [details]
Patch
Comment on attachment 195846 [details] Patch Attachment 195846 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17374168 New failing tests: http/tests/workers/terminate-during-sync-operation.html fast/multicol/vertical-rl/float-multicol.html Created attachment 195848 [details]
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04
Comment on attachment 195846 [details] Patch Attachment 195846 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17256598 New failing tests: fast/backgrounds/background-position-parsing.html Created attachment 195849 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 195850 [details]
Patch
Comment on attachment 195850 [details] Patch Attachment 195850 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17340831 New failing tests: fast/backgrounds/background-position-parsing.html Created attachment 195853 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 197942 [details]
Patch
Comment on attachment 197942 [details] Patch Attachment 197942 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/143207 New failing tests: fast/backgrounds/background-position-parsing.html http/tests/ssl/ping-with-unsafe-redirect.html Created attachment 197951 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 197942 [details] Patch Attachment 197942 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/143219 New failing tests: fast/backgrounds/background-position-parsing.html http/tests/ssl/ping-with-unsafe-redirect.html Created attachment 197953 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 197942 [details] Patch Attachment 197942 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/143257 New failing tests: fast/backgrounds/background-position-parsing.html http/tests/ssl/ping-with-unsafe-redirect.html Created attachment 197961 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 197980 [details]
Patch
Comment on attachment 197980 [details] Patch Attachment 197980 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/69145 New failing tests: fast/backgrounds/background-position-parsing.html http/tests/ssl/ping-with-unsafe-redirect.html Created attachment 197985 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.2
Comment on attachment 197980 [details] Patch Attachment 197980 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/113285 New failing tests: fast/backgrounds/background-position-parsing.html http/tests/ssl/ping-with-unsafe-redirect.html Created attachment 198022 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Created attachment 198139 [details]
Patch
Comment on attachment 198139 [details]
Patch
r=me
Comment on attachment 198139 [details] Patch Clearing flags on attachment: 198139 Committed r148523: <http://trac.webkit.org/changeset/148523> All reviewed patches have been landed. Closing bug. |
Created attachment 193923 [details] file to reproduce problem If you have a float whose height is a multiple of the surrounding text's line height (all specified in ems) Mac Chrome will wrap one more line than is necessary. Mac Safari (also tested Mac Firefox, Mac Opera and IE10) wrap the correct number of lines.