Bug 112731

Summary: Changes to VS2010 project files should only trigger builds on Windows bots.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
thorton: review-
patch v2 thorton: review+

Roger Fong
Reported 2013-03-19 12:12:04 PDT
Created attachment 193894 [details] patch Make builds only trigger for windows bots when changes are made to vcxproj, props or filters files.
Attachments
patch (1.31 KB, patch)
2013-03-19 12:12 PDT, Roger Fong 		thorton: review-
DetailsFormatted DiffDiff
patch v2 (1.43 KB, patch)
2013-03-19 13:07 PDT, Roger Fong 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-03-19 13:04:51 PDT
Comment on attachment 193894 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=193894&action=review > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:97 > + (r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]), This won't match any folders! Note the $. > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:-102 > - (r"\.vcproj/", ["win"]), This needs to stay. And vcxproj needs to be here too!
Roger Fong
Comment 2 2013-03-19 13:07:57 PDT
Created attachment 193904 [details] patch v2
Tim Horton
Comment 3 2013-03-19 14:35:01 PDT
Comment on attachment 193904 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=193904&action=review > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:97 > + (r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]), Assuming these extensions are actually unique to your platform. > BuildSlaveSupport/build.webkit.org-config/wkbuild.py:102 > + (r"\.(?:vcproj/|vcxproj/)", ["win"]), You could put the slash outside of the or :P
Roger Fong
Comment 4 2013-03-19 14:43:45 PDT
http://trac.webkit.org/changeset/146261
Note You need to log in before you can comment on or make changes to this bug.