Bug 112724

Summary: [CSS Grid Layout] Add parsing for grid-auto-{row|column}
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, eric, esprehn+autocc, macpherson, menard, ojan.autocc, ojan, tony, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 103333    
Attachments:
Description Flags
Proposed implementation, including a tiny refactoring. none

Julien Chaffraix
Reported 2013-03-19 11:35:56 PDT
As a first step to handle default grid items' sizing, we need to parse the new properties. Per the specification: grid-auto-row := <track-size> (it still uses the old name <track-minmax> in the spec but it's because it was forgotten in the renamings) This change requires us to tweak our implementation so that we can share code with grid-{rows|columns}.
Attachments
Proposed implementation, including a tiny refactoring. (29.26 KB, patch)
2013-03-19 13:02 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2013-03-19 13:02:33 PDT
Created attachment 193903 [details] Proposed implementation, including a tiny refactoring.
Tony Chang
Comment 2 2013-03-19 13:33:21 PDT
Comment on attachment 193903 [details] Proposed implementation, including a tiny refactoring. LGTM
WebKit Review Bot
Comment 3 2013-03-19 16:14:51 PDT
Comment on attachment 193903 [details] Proposed implementation, including a tiny refactoring. Clearing flags on attachment: 193903 Committed r146274: <http://trac.webkit.org/changeset/146274>
WebKit Review Bot
Comment 4 2013-03-19 16:14:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.