Bug 112712

Summary: IndexedDB: Remove onVersionChange(string) plumbing
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: WebCore Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alecflett, dglazkov, dgrogan, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 112715    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Joshua Bell 2013-03-19 10:22:52 PDT 
Active version changes are always to int versions (via open) or null (via deleteDatabase). Remove the backend->frontend plumbing for string version change notifications.

This will require a preliminary patch that switches the "null" case from going via the string to int. Then Chromium can drop unused code, and finally WebKit cleanup can happen.
Comment 1 Joshua Bell 2013-03-19 11:00:07 PDT 
Created attachment 193864 [details]
Patch
Comment 2 Joshua Bell 2013-03-19 11:01:05 PDT 
The patch here is dependent on https://bugs.webkit.org/show_bug.cgi?id=112715 landing first.

Also, some Chromium code needs to be deleted before this lands: https://codereview.chromium.org/12939002/
Comment 3 Joshua Bell 2013-03-21 10:14:30 PDT 
Created attachment 194286 [details]
Patch
Comment 4 Joshua Bell 2013-03-21 10:15:08 PDT 
Comment on attachment 194286 [details]
Patch

r? cq? anyone? - just deleting dead code
Comment 5 WebKit Review Bot 2013-03-21 10:16:44 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 6 WebKit Review Bot 2013-03-21 13:46:22 PDT 
Comment on attachment 194286 [details]
Patch

Clearing flags on attachment: 194286

Committed r146511: <http://trac.webkit.org/changeset/146511>
Comment 7 WebKit Review Bot 2013-03-21 13:46:26 PDT 
All reviewed patches have been landed.  Closing bug.