Bug 112695

Summary:

Web Inspector: Make workingCopy() and isDirty() methods of UISourceCode to be lazy

Product:

WebKit

Reporter:

Andrey Lushnikov <lushnikov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Lushnikov <lushnikov>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, bburg, buildbot, dglazkov, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

116924

Attachments:

Description	Flags
Patch	none
Patch	buildbot: commit-queue-

Andrey Lushnikov

Reported 2013-03-19 06:47:50 PDT

Make UISourceCode.workingCopy() and UISourceCode.isDirty() methods of UISourceCode to be lazy.

Attachments
Patch (14.49 KB, patch) 2013-03-19 06:55 PDT, Andrey Lushnikov	no flags	Details Formatted Diff Diff
Patch (14.51 KB, patch) 2013-03-19 07:13 PDT, Andrey Lushnikov	buildbot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrey Lushnikov

Comment 1 2013-03-19 06:55:50 PDT

Created attachment 193816 [details] Patch

Andrey Lushnikov

Comment 2 2013-03-19 07:13:41 PDT

Created attachment 193820 [details] Patch

Build Bot

Comment 3 2013-03-19 08:10:23 PDT

Comment on attachment 193820 [details] Patch Attachment 193820 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17246019 New failing tests: inspector/debugger/script-formatter-console.html inspector/styles/edit-inspector-stylesheet.html

WebKit Review Bot

Comment 4 2013-03-19 08:30:16 PDT

Comment on attachment 193820 [details] Patch Attachment 193820 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17227197 New failing tests: inspector/debugger/linkifier.html inspector/debugger/script-formatter-console.html inspector/debugger/script-formatter-breakpoints.html inspector/debugger/live-edit-breakpoints.html inspector/styles/edit-inspector-stylesheet.html

Build Bot

Comment 5 2013-03-19 11:29:31 PDT

Comment on attachment 193820 [details] Patch Attachment 193820 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17247067 New failing tests: inspector/debugger/script-formatter-console.html inspector/styles/edit-inspector-stylesheet.html inspector/debugger/script-formatter-breakpoints.html

Vsevolod Vlasov

Comment 6 2013-03-27 01:00:46 PDT

Comment on attachment 193820 [details] Patch This needs some more work. Clearing r? for now.

Note You need to log in before you can comment on or make changes to this bug.