Bug 11266

Summary: [S60] Both RnD and SDK icons are being used
Product: WebKit Reporter: Bradley Morrison <bradley.morrison>
Component: Tools / TestsAssignee: Bradley Morrison <bradley.morrison>
Status: CLOSED FIXED    
Severity: Normal CC: S60webkit
Priority: P2    
Version: 420+   
Hardware: S60 Emulator   
OS: S60 3rd edition   
Attachments:
Description Flags
icons.mk queries envionment to determine which icons to create zalan: review+

Bradley Morrison
Reported 2006-10-12 10:57:37 PDT
Recent changes to WebKit\group\icons.mk are incorrect as icons are being created/checked for both RnD and SDK locations. Only one or the other should be created. Depending on the style of compilation.
Attachments
icons.mk queries envionment to determine which icons to create (3.50 KB, patch)
2006-10-12 11:29 PDT, Bradley Morrison 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bradley Morrison
Comment 1 2006-10-12 11:01:32 PDT
The cleanest way to do this is to set an environment variable in the build script, and change icon.mk to generate/check the relevant type of icons depending on the value of that environment variable. I dumped the environment variable that the makefile has and while I could probably key it off something that already exists, it would probably be obscure and more difficult to maintain (like version numbers in MWCSym2Includes, for example). Therefore I think new environment variable BROWSER_SDK should be set. Surprising this has not been required before.
Bradley Morrison
Comment 2 2006-10-12 11:29:32 PDT
Created attachment 11049 [details] icons.mk queries envionment to determine which icons to create
alan
Comment 3 2006-10-12 11:43:53 PDT
Comment on attachment 11049 [details] icons.mk queries envionment to determine which icons to create r=me
Bradley Morrison
Comment 4 2006-10-12 11:51:40 PDT
(In reply to comment #3) > (From update of attachment 11049 [details] [edit]) > r=me > Thanks - applied r17012
Krishna
Comment 5 2006-10-16 10:50:18 PDT
TSW ID: KPOY-6UMLFN
Krishna
Comment 6 2006-10-27 18:20:04 PDT
S60WebKitTrunkSDK\20061027161039 Also Closed.
Note You need to log in before you can comment on or make changes to this bug.