Bug 112655

Summary: text-combine-upright text-shadow is not correctly positioned
Product: WebKit Reporter: Yuki Sekiguchi <yuki.sekiguchi>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, bfulgham, dglazkov, eric, esprehn+autocc, ntim, ojan.autocc, simon.fraser, webkit-bug-importer, webkit.review.bot, zalan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
See Also: https://github.com/web-platform-tests/wpt/pull/36613
Attachments:
Description Flags
reproduced html content
none
Patch
none
Patch none

Yuki Sekiguchi
Reported 2013-03-18 21:23:51 PDT
Created attachment 193722 [details] reproduced html content In the attached content, the text shadow of text-combine `12' should be at the lower right of the text, but at the upper right. On Safari for Mac, the position of upright text's text shadow is correct. Chromium may be wrong. I fix the bug at Bug 112558 .
Attachments
reproduced html content (466 bytes, text/html)
2013-03-18 21:23 PDT, Yuki Sekiguchi 		no flags
Details
Patch (11.92 KB, patch)
2013-03-18 22:03 PDT, Yuki Sekiguchi 		no flags
DetailsFormatted DiffDiff
Patch (12.69 KB, patch)
2013-03-18 22:56 PDT, Yuki Sekiguchi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuki Sekiguchi
Comment 1 2013-03-18 22:03:49 PDT
Created attachment 193726 [details] Patch
WebKit Review Bot
Comment 2 2013-03-18 22:46:34 PDT
Comment on attachment 193726 [details] Patch Attachment 193726 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17188604 New failing tests: fast/writing-mode/combine-text-shadow.html
Yuki Sekiguchi
Comment 3 2013-03-18 22:56:14 PDT
Created attachment 193737 [details] Patch
Andreas Kling
Comment 4 2014-02-05 11:25:21 PST
Comment on attachment 193737 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Yuki Sekiguchi
Comment 5 2014-02-06 03:17:18 PST
Bug 127324 hides this bug. I'll resend patch if the bug is fixed.
Ahmad Saleem
Comment 6 2022-10-22 02:24:36 PDT
It is still broken for combined text based on the "reproduced html content" and I think we need to add "const TextBoxPainter& shouldRotate" in here: https://github.com/WebKit/WebKit/blob/42fe4a9f7ac5d2ecb5bd81e40ff9524f445e22ef/Source/WebCore/rendering/TextPainter.cpp#L132 and then update this: https://github.com/WebKit/WebKit/blob/42fe4a9f7ac5d2ecb5bd81e40ff9524f445e22ef/Source/WebCore/rendering/TextPainter.cpp#L208 by adding (!shouldRotate) as condition. I am not sure whether we need to update other two places or not, which the patch was trying to modify. If someone confirm that this is right approach, I am happy to do PR with giving credit to Yuki. Thanks!
Radar WebKit Bug Importer
Comment 7 2022-10-22 21:01:20 PDT
<rdar://problem/101467340>
Tim Nguyen (:ntim)
Comment 8 2022-10-22 21:06:02 PDT
Pull request: https://github.com/WebKit/WebKit/pull/5680
Tim Nguyen (:ntim)
Comment 9 2022-10-22 21:09:10 PDT
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/36613
EWS
Comment 10 2022-10-23 00:02:38 PDT
Committed 255892@main (0acf2457faa7): <https://commits.webkit.org/255892@main> Reviewed commits have been landed. Closing PR #5680 and removing active labels.
Tim Nguyen (:ntim)
Comment 11 2022-12-24 15:53:09 PST
*** Bug 234843 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.