| Summary: | JSC_NATIVE_FUNCTION() takes an identifier for the name and then uses #name, which is unsafe if name was already #define'd to something else | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, roger_fong, sam, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 193685 [details]
the patch
Comment on attachment 193685 [details]
the patch
r=me
Comment on attachment 193685 [details]
the patch
Yup, tests pass now!
Comment on attachment 193685 [details] the patch Clearing flags on attachment: 193685 Committed r146157: <http://trac.webkit.org/changeset/146157> All reviewed patches have been landed. Closing bug. |
In this case, we have Windows #define'ing 'small' to be something other than 'small', and StringPrototype does: JSC_NATIVE_FUNCTION(small, stringProtoFuncSmall, DontEnum, 0); The solution is to make JSC_NATIVE_FUNCTION just take a C string directly.