Bug 112604

Summary: [WinCairo] Build WinCairo WTF and JavaScriptCore Projects under VS2010
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First part of change adding top-level solution labels for Debug/Release_WinCairo
thorton: review+
Second part of patch. Land WTF changes.
thorton: review+
Third part of patch: Land JavaScriptCore updates.
none
Bad patch.
none
Third part of patch: Land JavaScriptCore changes.
thorton: review+
Fix for testapi build under WinCairo thorton: review+

Description Brent Fulgham 2013-03-18 11:41:35 PDT
This set of patches updates the VS2010 projects to build the WinCairo target.
Comment 1 Brent Fulgham 2013-03-18 12:01:06 PDT
Created attachment 193623 [details]
First part of change adding top-level solution labels for Debug/Release_WinCairo
Comment 2 Brent Fulgham 2013-03-18 12:02:19 PDT
First patch: Just add a set of do-nothing "WinCairo" build targets.  These will be filled in at specific project-level build settings as needed.  Not all projects will need any special handling, so no project-specific build targets have been created yet.
Comment 3 Brent Fulgham 2013-03-18 13:29:30 PDT
Comment on attachment 193623 [details]
First part of change adding top-level solution labels for Debug/Release_WinCairo

Initial step in landing WinCairo VS2010 build.
Comment 4 Brent Fulgham 2013-03-18 13:29:58 PDT
Created attachment 193639 [details]
Second part of patch. Land WTF changes.
Comment 5 Brent Fulgham 2013-03-18 13:30:56 PDT
Comment on attachment 193639 [details]
Second part of patch. Land WTF changes.

This patch adds Debug_WinCairo/Release_WinCairo targets so headers get copied to proper build folder.
Comment 6 Brent Fulgham 2013-03-18 13:36:24 PDT
Created attachment 193640 [details]
Third part of patch: Land JavaScriptCore updates.
Comment 7 Brent Fulgham 2013-03-18 13:37:17 PDT
Comment on attachment 193640 [details]
Third part of patch: Land JavaScriptCore updates.

This patch gets the WinCairo/CFLite-only build of JavaScriptCore working under VS2010.
Comment 8 Brent Fulgham 2013-03-18 14:11:07 PDT
First patch landed in r146120.
Comment 9 Brent Fulgham 2013-03-18 14:12:08 PDT
Second patch landed in r146121.
Comment 10 Brent Fulgham 2013-03-18 14:16:29 PDT
Created attachment 193648 [details]
Bad patch.
Comment 11 Brent Fulgham 2013-03-18 14:17:44 PDT
Comment on attachment 193648 [details]
Bad patch.

Revised bug to correct jsc and LLInt* projects.
Comment 12 Brent Fulgham 2013-03-18 14:23:49 PDT
Created attachment 193653 [details]
Third part of patch: Land JavaScriptCore changes.
Comment 13 Brent Fulgham 2013-03-18 15:54:05 PDT
Created attachment 193677 [details]
Fix for testapi build under WinCairo
Comment 14 Brent Fulgham 2013-03-18 15:54:45 PDT
Comment on attachment 193677 [details]
Fix for testapi build under WinCairo

Didn't notice that this was still linking against official Apple CoreFoundation.lib. Corrected to use CFLite.lib.
Comment 15 Brent Fulgham 2013-03-18 16:20:53 PDT
Third patch landed in r146123.
Comment 16 Brent Fulgham 2013-03-18 16:21:25 PDT
Testapi build correction landed under r146144.
Comment 17 Brent Fulgham 2013-03-18 16:22:08 PDT
All patches landed.