Bug 112604

Summary:

[WinCairo] Build WinCairo WTF and JavaScriptCore Projects under VS2010

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

roger_fong, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
First part of change adding top-level solution labels for Debug/Release_WinCairo	thorton: review+
Second part of patch. Land WTF changes.	thorton: review+
Third part of patch: Land JavaScriptCore updates.	none
Bad patch.	none
Third part of patch: Land JavaScriptCore changes.	thorton: review+
Fix for testapi build under WinCairo	thorton: review+

Brent Fulgham

Reported 2013-03-18 11:41:35 PDT

This set of patches updates the VS2010 projects to build the WinCairo target.

Attachments
First part of change adding top-level solution labels for Debug/Release_WinCairo (25.19 KB, patch) 2013-03-18 12:01 PDT, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
Second part of patch. Land WTF changes. (13.20 KB, patch) 2013-03-18 13:29 PDT, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
Third part of patch: Land JavaScriptCore updates. (22.97 KB, patch) 2013-03-18 13:36 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Bad patch. (65.34 KB, patch) 2013-03-18 14:16 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Third part of patch: Land JavaScriptCore changes. (63.48 KB, patch) 2013-03-18 14:23 PDT, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
Fix for testapi build under WinCairo (6.13 KB, patch) 2013-03-18 15:54 PDT, Brent Fulgham	thorton: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2013-03-18 12:01:06 PDT

Created attachment 193623 [details] First part of change adding top-level solution labels for Debug/Release_WinCairo

Brent Fulgham

Comment 2 2013-03-18 12:02:19 PDT

First patch: Just add a set of do-nothing "WinCairo" build targets. These will be filled in at specific project-level build settings as needed. Not all projects will need any special handling, so no project-specific build targets have been created yet.

Brent Fulgham

Comment 3 2013-03-18 13:29:30 PDT

Comment on attachment 193623 [details] First part of change adding top-level solution labels for Debug/Release_WinCairo Initial step in landing WinCairo VS2010 build.

Brent Fulgham

Comment 4 2013-03-18 13:29:58 PDT

Created attachment 193639 [details] Second part of patch. Land WTF changes.

Brent Fulgham

Comment 5 2013-03-18 13:30:56 PDT

Comment on attachment 193639 [details] Second part of patch. Land WTF changes. This patch adds Debug_WinCairo/Release_WinCairo targets so headers get copied to proper build folder.

Brent Fulgham

Comment 6 2013-03-18 13:36:24 PDT

Created attachment 193640 [details] Third part of patch: Land JavaScriptCore updates.

Brent Fulgham

Comment 7 2013-03-18 13:37:17 PDT

Comment on attachment 193640 [details] Third part of patch: Land JavaScriptCore updates. This patch gets the WinCairo/CFLite-only build of JavaScriptCore working under VS2010.

Brent Fulgham

Comment 8 2013-03-18 14:11:07 PDT

First patch landed in r146120.

Brent Fulgham

Comment 9 2013-03-18 14:12:08 PDT

Second patch landed in r146121.

Brent Fulgham

Comment 10 2013-03-18 14:16:29 PDT

Created attachment 193648 [details] Bad patch.

Brent Fulgham

Comment 11 2013-03-18 14:17:44 PDT

Comment on attachment 193648 [details] Bad patch. Revised bug to correct jsc and LLInt* projects.

Brent Fulgham

Comment 12 2013-03-18 14:23:49 PDT

Created attachment 193653 [details] Third part of patch: Land JavaScriptCore changes.

Brent Fulgham

Comment 13 2013-03-18 15:54:05 PDT

Created attachment 193677 [details] Fix for testapi build under WinCairo

Brent Fulgham

Comment 14 2013-03-18 15:54:45 PDT

Comment on attachment 193677 [details] Fix for testapi build under WinCairo Didn't notice that this was still linking against official Apple CoreFoundation.lib. Corrected to use CFLite.lib.

Brent Fulgham

Comment 15 2013-03-18 16:20:53 PDT

Third patch landed in r146123.

Brent Fulgham

Comment 16 2013-03-18 16:21:25 PDT

Testapi build correction landed under r146144.

Brent Fulgham

Comment 17 2013-03-18 16:22:08 PDT

All patches landed.

Note You need to log in before you can comment on or make changes to this bug.