Bug 112562

Summary: Change RenderTableCell to use pixelSnappedSize when painting
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, esprehn+autocc, leviw, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2013-03-18 06:13:00 PDT
Change the paining code in RenderTableCell to use the pixel snapped size to ensure consistent rounding given that the location was rounded during layout. It is currently constructing a paint rect by taking the rounded location and the precise size and then pixel snapping it. This causes the size to be rounded incorrectly. By instead using the pixel snapped size the rounding problem can be avoided. Downstream chromium bug: https://code.google.com/p/chromium/issues/detail?id=194333
Attachments
Patch (45.29 KB, patch)
2013-03-18 06:16 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2013-03-18 06:16:54 PDT
Created attachment 193546 [details] Patch
Emil A Eklund
Comment 2 2013-03-18 06:20:40 PDT
The tables/mozilla/bugs/bug73321.html test actually showed this problem as well, the dark-gray line in the lower right corner was one pixel too wide before. That is the only difference in the rebaselined image result.
WebKit Review Bot
Comment 3 2013-03-18 09:18:44 PDT
Comment on attachment 193546 [details] Patch Clearing flags on attachment: 193546 Committed r146072: <http://trac.webkit.org/changeset/146072>
WebKit Review Bot
Comment 4 2013-03-18 09:18:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.