Bug 112549

Summary: monochrome media feature does not accept integer values
Product: WebKit Reporter: Rune Lillesveen <rune>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, eric.carlson, esprehn+autocc, feature-media-reviews, jer.noble, macpherson, menard, ojan.autocc, rniwa, webkit.review.bot, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kenneth: review+

Rune Lillesveen
Reported 2013-03-18 03:07:17 PDT
The monochrome media feature should accept non-negative integers as specified in the Media Queries spec. For instance: /* Match non-monochrome displays. */ @media (monochrome: 0) {} /* Match monochrome displays with 8 bits per pixel. */ @media all and (monochrome: 8) {}
Attachments
Patch (3.30 KB, patch)
2013-03-18 04:39 PDT, Rune Lillesveen 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rune Lillesveen
Comment 1 2013-03-18 04:39:12 PDT
Created attachment 193526 [details] Patch
Ahmad Saleem
Comment 2 2022-06-09 09:30:13 PDT
I think patch landed since I can see the line of code in Webkit Github mirror as below: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/css/MediaQueryExpression.cpp#L135 Unless, if test cases needs to be merged or something else is required here. I think this can be closed. Thanks!
Alexey Proskuryakov
Comment 3 2022-06-09 11:34:38 PDT
Looks like this got added in 2016 with bug 161537.
Note You need to log in before you can comment on or make changes to this bug.