Bug 112541

Summary: The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
Product: WebKit Reporter: Kunihiko Sakamoto <ksakamoto>
Component: FormsAssignee: Kunihiko Sakamoto <ksakamoto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, mibalan, mifenton, ojan.autocc, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
URL: http://jsfiddle.net/unyta/2/
Attachments:
Description Flags
Patch none

Description Kunihiko Sakamoto 2013-03-18 01:34:54 PDT 
https://code.google.com/p/chromium/issues/detail?id=196529
The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
Comment 1 Kunihiko Sakamoto 2013-03-18 01:56:18 PDT 
Created attachment 193505 [details]
Patch
Comment 2 Kent Tamura 2013-03-18 04:40:13 PDT 
Comment on attachment 193505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193505&action=review

> Source/WebCore/html/HTMLFormElement.cpp:210
> +            return static_cast<HTMLFormControlElement*>(node);

Oh, we should have toHTMLFormControlElement(). static_cast<> should be avoided.
Comment 3 WebKit Review Bot 2013-03-18 04:51:17 PDT 
Comment on attachment 193505 [details]
Patch

Clearing flags on attachment: 193505

Committed r146055: <http://trac.webkit.org/changeset/146055>
Comment 4 WebKit Review Bot 2013-03-18 04:51:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Mihai Balan 2013-03-18 05:57:39 PDT 
I tried opening the fiddle in Chrome Canary Version 27.0.1443.2 canary - and it crashed the tab. You might want to take a(nother) look at it.
Comment 6 Kunihiko Sakamoto 2013-03-18 18:21:51 PDT 
I have tried 27.0.1444.3 canary ant it didn't crash.
I believe 27.0.1443.2 canary doesn't include this fix - maybe yow saw a different bug.
Comment 7 Mihai Balan 2013-03-19 01:41:50 PDT 
Yeah, might have been a glitch - it doesn't crash on Canary 27.0.1444.3 for me neither