Bug 112507

Summary: Only add wordspacing when kerning to actual word ends
Product: WebKit Reporter: Dean Jackson <dino>
Component: TextAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: enrica, eric, esprehn+autocc, leviw, mitz, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 112610    
Attachments:
Description Flags
Patch
none
Patch
none
Patch enrica: review+

Dean Jackson
Reported 2013-03-16 17:30:52 PDT
When measuring text in kerning mode, we currently add the word spacing to every wordMeasurement. However, not all are actual word breaks. <rdar://problem/12945869>
Attachments
Patch (4.37 KB, patch)
2013-03-16 17:38 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2013-03-17 04:28 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (4.42 KB, patch)
2013-03-18 10:51 PDT, Dean Jackson 		enrica: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-03-16 17:38:13 PDT
Created attachment 193449 [details] Patch
Dean Jackson
Comment 2 2013-03-17 04:28:12 PDT
Created attachment 193461 [details] Patch
Enrica Casucci
Comment 3 2013-03-18 10:39:01 PDT
The patch doesn't contain the test, only the ChangeLog for LayoutTests.
Dean Jackson
Comment 4 2013-03-18 10:51:10 PDT
Created attachment 193602 [details] Patch
Enrica Casucci
Comment 5 2013-03-18 10:56:46 PDT
Comment on attachment 193602 [details] Patch Looks good. Thanks for fixing this!
Dean Jackson
Comment 6 2013-03-18 11:06:03 PDT
Committed r146087: <http://trac.webkit.org/changeset/146087>
Note You need to log in before you can comment on or make changes to this bug.