Bug 112465

Summary: [chromium] Remove code that relies on boundsContainsPageScale().
Product: WebKit Reporter: W. James MacLean <wjmaclean>
Component: New BugsAssignee: W. James MacLean <wjmaclean>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aelias, cc-bugs, dglazkov, enne, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description W. James MacLean 2013-03-15 13:35:58 PDT
[chromium] Remove NCCH code that relies on boundsContainsPageScale().
Comment 1 W. James MacLean 2013-03-15 14:06:29 PDT
Created attachment 193371 [details]
Patch
Comment 2 W. James MacLean 2013-03-15 14:07:41 PDT
aelias@ asked if I could remove this (soon to be) dead code.
Comment 3 Adrienne Walker 2013-03-15 18:21:38 PDT
What about boundsContainPageScale and setBoundsContainPageScale in WebContentLayer?

What about the boundsContainPageScale calls in GraphicsLayerChromium?
Comment 4 W. James MacLean 2013-03-15 22:51:17 PDT
(In reply to comment #3)
> What about boundsContainPageScale and setBoundsContainPageScale in WebContentLayer?
> 
> What about the boundsContainPageScale calls in GraphicsLayerChromium?

Ahh, ok. I had thought aelias@ was just concerned about the stuff in NCCH. I'll track down all the occurences then and do them in a single CL.
Comment 5 W. James MacLean 2013-03-18 06:15:48 PDT
Created attachment 193545 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-18 06:17:32 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 7 W. James MacLean 2013-03-18 07:32:36 PDT
Renaming issue to reflect we're no longer just modifying NCCH.
Comment 8 WebKit Review Bot 2013-03-18 15:45:41 PDT
Comment on attachment 193545 [details]
Patch

Clearing flags on attachment: 193545

Committed r146135: <http://trac.webkit.org/changeset/146135>
Comment 9 WebKit Review Bot 2013-03-18 15:45:45 PDT
All reviewed patches have been landed.  Closing bug.