Bug 112441

Summary:

Move font-family applying code to StyleBuilder

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

CSS

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, buildbot, dglazkov, eric, esprehn+autocc, macpherson, menard, ojan.autocc, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

89879

Attachments:

Description	Flags
Patch	none
Patch	none

Emil A Eklund

Reported 2013-03-15 06:37:50 PDT

Many of the font related properties were moved to StyleBuilder in r87362 two years ago. Move font-family as well so that all font properties are handled the same way.

Attachments
Patch (16.87 KB, patch) 2013-03-15 07:36 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Patch (13.85 KB, patch) 2013-03-17 08:22 PDT, Emil A Eklund	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Emil A Eklund

Comment 1 2013-03-15 07:36:53 PDT

Created attachment 193305 [details] Patch

Build Bot

Comment 2 2013-03-15 08:42:04 PDT

Comment on attachment 193305 [details] Patch Attachment 193305 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17232041 New failing tests: css3/selectors3/xml/css3-modsel-24.xml accessibility/radio-button-group-members.html css3/selectors3/xhtml/css3-modsel-24.xml css1/box_properties/acid_test.html css3/selectors3/xml/css3-modsel-64.xml css3/selectors3/xhtml/css3-modsel-68.xml css2.1/t09-c5526c-display-00-e.html css3/selectors3/xhtml/css3-modsel-161.xml css3/selectors3/xml/css3-modsel-70.xml css3/selectors3/xhtml/css3-modsel-23.xml css3/selectors3/html/css3-modsel-64.html css3/selectors3/html/css3-modsel-24.html css3/selectors3/xhtml/css3-modsel-64.xml compositing/overflow/theme-affects-visual-overflow.html css3/selectors3/xhtml/css3-modsel-70.xml css3/selectors3/xml/css3-modsel-23.xml css3/selectors3/xml/css3-modsel-19b.xml css3/selectors3/html/css3-modsel-161.html css3/selectors3/xml/css3-modsel-25.xml css3/selectors3/xhtml/css3-modsel-25.xml css3/selectors3/html/css3-modsel-23.html css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/xhtml/css3-modsel-19b.xml css3/selectors3/html/css3-modsel-19b.html css3/selectors3/xhtml/css3-modsel-69.xml css3/selectors3/html/css3-modsel-69.html css3/selectors3/html/css3-modsel-70.html css3/selectors3/html/css3-modsel-25.html css3/selectors3/html/css3-modsel-68.html css3/selectors3/xml/css3-modsel-69.xml

Allan Sandfeld Jensen

Comment 3 2013-03-15 08:58:36 PDT

Where did all the logic from the 'CSSPropertyFont' case go? Is that not necessary any more?

WebKit Review Bot

Comment 4 2013-03-15 10:09:49 PDT

Comment on attachment 193305 [details] Patch Attachment 193305 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17066612 New failing tests: css3/selectors3/xml/css3-modsel-24.xml editing/pasteboard/4806874.html css3/selectors3/xhtml/css3-modsel-24.xml http/tests/cache/subresource-failover-to-network.html css3/selectors3/xml/css3-modsel-64.xml css3/selectors3/html/css3-modsel-24.html css3/selectors3/html/css3-modsel-64.html css3/selectors3/html/css3-modsel-68.html css3/selectors3/xhtml/css3-modsel-64.xml css3/selectors3/xml/css3-modsel-23.xml editing/selection/3690703-2.html editing/input/caret-at-the-edge-of-input.html css3/selectors3/xhtml/css3-modsel-69.xml css3/selectors3/xml/css3-modsel-19b.xml css3/selectors3/xml/css3-modsel-161.xml css3/flexbox/button.html css3/selectors3/xml/css3-modsel-69.xml css3/selectors3/html/css3-modsel-161.html css3/selectors3/xhtml/css3-modsel-19b.xml editing/inserting/before-after-input-element.html css3/selectors3/html/css3-modsel-23.html css3/selectors3/xml/css3-modsel-68.xml css3/selectors3/html/css3-modsel-69.html css2.1/20110323/replaced-elements-001.htm css3/selectors3/html/css3-modsel-19b.html css3/selectors3/xhtml/css3-modsel-68.xml editing/selection/3690703.html editing/pasteboard/4641033.html css3/selectors3/xhtml/css3-modsel-23.xml css3/selectors3/xhtml/css3-modsel-161.xml

Eric Seidel (no email)

Comment 5 2013-03-15 11:55:44 PDT

Comment on attachment 193305 [details] Patch The idea seems fine. Looks like you have some failures, so marking r-. This makes me realize that we need to come up with some pretty pictures explaining all the classes in the style system like how we did for the HTML parser and loaders subsystems.

Emil A Eklund

Comment 6 2013-03-17 08:21:27 PDT

Oops, bad merge. Will upload a new patch that passes the tests in a minute.

Emil A Eklund

Comment 7 2013-03-17 08:22:19 PDT

Created attachment 193466 [details] Patch

Emil A Eklund

Comment 8 2013-03-17 10:05:48 PDT

Comment on attachment 193466 [details] Patch Thanks Allan!

WebKit Review Bot

Comment 9 2013-03-17 10:16:52 PDT

Comment on attachment 193466 [details] Patch Clearing flags on attachment: 193466 Committed r146014: <http://trac.webkit.org/changeset/146014>

WebKit Review Bot

Comment 10 2013-03-17 10:16:56 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.