Bug 112429

Summary: Web Inspector: Timeline. Clear button doesn't clean Memory graph in Overview pane.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Roland Takacs <rtakacs>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, commit-queue, keishi, loislo, pfeldman, pmuellr, rtakacs, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 116924    
Attachments:
Description Flags
patch
noam: review+, noam: commit-queue-
patch none

Description Ilya Tikhonovsky 2013-03-15 04:36:41 PDT
EOM
Comment 1 Roland Takacs 2013-06-05 01:21:10 PDT
Created attachment 203767 [details]
patch

With this patch we can remove the memory graph from the canvas.
Comment 2 Noam Rosenthal 2013-06-05 01:44:17 PDT
Comment on attachment 203767 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203767&action=review

> Source/WebCore/ChangeLog:8
> +        There is too early return from TimelineMemoryOverview.update() when

There is an early return

> Source/WebCore/ChangeLog:9
> +        record array is empty. Thats why if you clik onto the clear button,

click

> Source/WebCore/ChangeLog:13
> +        I've moved this "return condition" after the canvas size definition
> +        because we need to know the canvas size for refreshing.
> +        I've overridden TimelineOverviewBase's reset function to clear

I've moved -> Moved
I've overridden -> Overridden
Comment 3 Roland Takacs 2013-06-05 03:19:48 PDT
Created attachment 203783 [details]
patch
Comment 4 WebKit Commit Bot 2013-06-05 05:36:57 PDT
Comment on attachment 203783 [details]
patch

Clearing flags on attachment: 203783

Committed r151217: <http://trac.webkit.org/changeset/151217>
Comment 5 WebKit Commit Bot 2013-06-05 05:37:00 PDT
All reviewed patches have been landed.  Closing bug.