Bug 112411 – WebKitCSSKeyframesRule.idl should have item method

• Component: New Bugs
• Status: RESOLVED WONTFIX

[foo]

WebKitCSSKeyframesRule.idl should have item method

[foo]

Created attachment 193243 [details]
Patch

[foo]

Currently only WebKitCSSKeyframesRule.idl doesn't have item() and have [IndexedGetter].

[Kentaro Hara]

Comment on attachment 193243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193243&action=review

> Source/WebCore/ChangeLog:10
> +        There is WebKitCSSKeyframesRule::item() method but WebKitCSSKeyframesRule.idl doesn't have item method.
> +        Currently CodeGeneratorV8 have to treat WebKitCSSKeyframesRule specially due to lack of item() definition.
> +        (On the other hand it seems that JSC generator doesn't need to get IndexGetter's return type from IDL.)

What is the spec saying? We should follow the spec.

> Source/WebCore/ChangeLog:12
> +        No new tests, refactoring only. No run-bindings-tests changes.

This is not refactoring. You're changing behavior that is exposed to outside. You have to add layout tests. (But before that I'd like to confirm what the spec is saying.)

[foo]

Regarding the working draft, there is no item method in CSSKeyframesRule.
http://www.w3.org/TR/css3-animations/#csskeyframesrule

Meanwhile, WebKitCSSKeyframesRule.idl has [IndexedGetter] attribute.
According to the WebKitIDL spec, the bindings code for indexed getters is generated automatically so that XXX[i] behaves equivalent to XXX.item(i).
This implies the interface should have item method.
http://trac.webkit.org/wiki/WebKitIDL#IndexedGetter

Thus here my conclusion is:
(1) This patch is not good.
(2) There's inconsistency between CSS3 Animations Working draft and WebKitIDL.
    ([IndexedGetter] but no item() method in WebKitIDL)

[Kentaro Hara]

(In reply to comment #4)
> Regarding the working draft, there is no item method in CSSKeyframesRule.
> http://www.w3.org/TR/css3-animations/#csskeyframesrule
> 
> Meanwhile, WebKitCSSKeyframesRule.idl has [IndexedGetter] attribute.
> According to the WebKitIDL spec, the bindings code for indexed getters is generated automatically so that XXX[i] behaves equivalent to XXX.item(i).
> This implies the interface should have item method.
> http://trac.webkit.org/wiki/WebKitIDL#IndexedGetter
> 
> Thus here my conclusion is:
> (1) This patch is not good.
> (2) There's inconsistency between CSS3 Animations Working draft and WebKitIDL.
>     ([IndexedGetter] but no item() method in WebKitIDL)

Thanks, so a right fix would be either of:

[1] Remove [IndexedGetter] from WebKitIDL according to the spec.
[2] Propose to add [IndexedGetter] and item() to the spec.

CC-ing spec folks.

[Ahmad Saleem]

[e-mail] & [e-mail] - Is this needed anymore? Thanks!

[Ryosuke Niwa]

This is won't fix at this point.

[Ryosuke Niwa]

Tracking the addition of index getter to the spec in https://github.com/w3c/csswg-drafts/issues/7684.