Bug 112399

Summary: Convert inspector to new-flexbox
Product: WebKit Reporter: Christian Biesinger <cbiesinger>
Component: New BugsAssignee: Christian Biesinger <cbiesinger>
Status: RESOLVED FIXED    
Severity: Normal CC: caseq, ojan, pfeldman, vsevik, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Christian Biesinger
Reported 2013-03-14 19:16:35 PDT
Convert inspector to new-flexbox
Attachments
Patch (10.45 KB, patch)
2013-03-14 19:18 PDT, Christian Biesinger 		no flags
DetailsFormatted DiffDiff
Patch (10.45 KB, patch)
2013-03-15 11:23 PDT, Christian Biesinger 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Christian Biesinger
Comment 1 2013-03-14 19:18:13 PDT
Created attachment 193221 [details] Patch
Christian Biesinger
Comment 2 2013-03-14 19:19:54 PDT
I believe this and the other pending patches finish up my elimination of old-flexbox. Pavel, I tried to test this patch but I am not sure that my clicking around in inspector covered all the CSS classes I'm touching. Any suggestions for testing?
Ojan Vafai
Comment 3 2013-03-14 23:27:51 PDT
LGTM. I'll leave it for one of the inspector folks to R+ though.
Andrey Kosyakov
Comment 4 2013-03-15 02:20:55 PDT
Comment on attachment 193221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193221&action=review > Source/WebCore/inspector/front-end/inspector.css:249 > + -webkit-flex-direction: column; you're changing "-webkit-box-orient: horizontal" to "-webkit-flex-direction: column" -- is this intentional? The difference probably won't be noticeable now, given that we dropped icons for toolbar items. You can perhaps just drop direction.
Andrey Kosyakov
Comment 5 2013-03-15 02:25:14 PDT
Other than the nit mentioned above, LGTM. I did not spot any visual regressions either.
Christian Biesinger
Comment 6 2013-03-15 11:23:44 PDT
Created attachment 193340 [details] Patch
Christian Biesinger
Comment 7 2013-03-15 11:25:17 PDT
Changed to row.
Pavel Feldman
Comment 8 2013-03-15 13:14:04 PDT
We did not drop icons. It is behind setting.
Christian Biesinger
Comment 9 2013-03-15 13:16:57 PDT
OK, at least with the new patch, the toolbar looks right when I enable icons.
WebKit Review Bot
Comment 10 2013-03-15 14:53:02 PDT
Comment on attachment 193340 [details] Patch Clearing flags on attachment: 193340 Committed r145943: <http://trac.webkit.org/changeset/145943>
WebKit Review Bot
Comment 11 2013-03-15 14:53:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.