Bug 112301 – Add support for MediaSource::isTypeSupported()

• Component: Media
• Status: RESOLVED FIXED

[Aaron Colwell]

Add support for MediaSource::isTypeSupported()

[Aaron Colwell]

Created attachment 193024 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Darin Fisher (:fishd, Google)]

Comment on attachment 193024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193024&action=review

We usually put MIME-type related queries on WebMIMERegistry.  However, I notice that this is not a function on WebCore::MIMERegistry, although I suppose it could be.


> Source/WebKit/chromium/src/MediaSourcePrivateImpl.cpp:46
> +    return WebKit::webKitPlatformSupport()->isTypeSupportedForMediaSource(type, codecs);

nit: webKitPlatformSupport() is deprecated.  You should be using WebKit::Platform::current() instead.

[Aaron Colwell]

Created attachment 193161 [details]
Patch

[WebKit Review Bot]

Comment on attachment 193161 [details]
Patch

Attachment 193161 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17194230

[WebKit Review Bot]

Comment on attachment 193161 [details]
Patch

Attachment 193161 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17036857

[Darin Fisher (:fishd, Google)]

Comment on attachment 193161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review

> Source/Platform/chromium/public/WebMimeRegistry.h:54
> +

tangent: is it possible to resolve the above FIXME now?

[Darin Fisher (:fishd, Google)]

Comment on attachment 193161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review

> Source/Platform/chromium/public/WebMimeRegistry.h:55
> +    virtual bool supportsMediaSourceMIMEType(const WebKit::WebString& mimeType, const WebKit::WebString& codecs) = 0;

note: we typically provide default implementations for interfaces that are intended to be implemented by chromium.  that way, the webkit side can land first.

[Aaron Colwell]

Comment on attachment 193161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review

>> Source/Platform/chromium/public/WebMimeRegistry.h:54
>> +
> 
> tangent: is it possible to resolve the above FIXME now?

Yes. I'll do this in a separate patch.

>> Source/Platform/chromium/public/WebMimeRegistry.h:55
>> +    virtual bool supportsMediaSourceMIMEType(const WebKit::WebString& mimeType, const WebKit::WebString& codecs) = 0;
> 
> note: we typically provide default implementations for interfaces that are intended to be implemented by chromium.  that way, the webkit side can land first.

I can do that, but then the LayoutTest will fail. Should I add TestExpectation line for this and file a bug to remove it once the Chromium side lands?

[Peter Beverloo (cr-android ews)]

Comment on attachment 193161 [details]
Patch

Attachment 193161 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17134605

[Aaron Colwell]

Created attachment 194083 [details]
Rebase

[WebKit Review Bot]

Comment on attachment 194083 [details]
Rebase

Clearing flags on attachment: 194083

Committed r146360: <http://trac.webkit.org/changeset/146360>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.