Summary: | Add support for MediaSource::isTypeSupported() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aaron Colwell <acolwell> | ||||||||
Component: | Media | Assignee: | Aaron Colwell <acolwell> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, dglazkov, eric.carlson, esprehn+autocc, feature-media-reviews, fishd, jamesr, jer.noble, ojan.autocc, peter+ews, tkent+wkapi, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Aaron Colwell
2013-03-13 16:54:18 PDT
Created attachment 193024 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 193024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193024&action=review We usually put MIME-type related queries on WebMIMERegistry. However, I notice that this is not a function on WebCore::MIMERegistry, although I suppose it could be. > Source/WebKit/chromium/src/MediaSourcePrivateImpl.cpp:46 > + return WebKit::webKitPlatformSupport()->isTypeSupportedForMediaSource(type, codecs); nit: webKitPlatformSupport() is deprecated. You should be using WebKit::Platform::current() instead. Created attachment 193161 [details]
Patch
Comment on attachment 193161 [details] Patch Attachment 193161 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17194230 Comment on attachment 193161 [details] Patch Attachment 193161 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17036857 Comment on attachment 193161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review > Source/Platform/chromium/public/WebMimeRegistry.h:54 > + tangent: is it possible to resolve the above FIXME now? Comment on attachment 193161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review > Source/Platform/chromium/public/WebMimeRegistry.h:55 > + virtual bool supportsMediaSourceMIMEType(const WebKit::WebString& mimeType, const WebKit::WebString& codecs) = 0; note: we typically provide default implementations for interfaces that are intended to be implemented by chromium. that way, the webkit side can land first. Comment on attachment 193161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193161&action=review >> Source/Platform/chromium/public/WebMimeRegistry.h:54 >> + > > tangent: is it possible to resolve the above FIXME now? Yes. I'll do this in a separate patch. >> Source/Platform/chromium/public/WebMimeRegistry.h:55 >> + virtual bool supportsMediaSourceMIMEType(const WebKit::WebString& mimeType, const WebKit::WebString& codecs) = 0; > > note: we typically provide default implementations for interfaces that are intended to be implemented by chromium. that way, the webkit side can land first. I can do that, but then the LayoutTest will fail. Should I add TestExpectation line for this and file a bug to remove it once the Chromium side lands? Comment on attachment 193161 [details] Patch Attachment 193161 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17134605 Created attachment 194083 [details]
Rebase
Comment on attachment 194083 [details] Rebase Clearing flags on attachment: 194083 Committed r146360: <http://trac.webkit.org/changeset/146360> All reviewed patches have been landed. Closing bug. |