Bug 112284 – Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false

• Component: New Bugs
• Status: RESOLVED FIXED

Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false

Created attachment 192982 [details]
Patch

[Adam Barth]

Comment on attachment 192982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192982&action=review

> Source/WebCore/ChangeLog:9
> +        Since webGLErrorsToConsoleEnabled is false durin layout tests, this change makes

durin -> during

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:399
> +        if (m_context->m_synthesizedErrorsToConsole)
> +            m_context->printGLErrorToConsole(message);

Why isn't this needed in DRT?  Perhaps the filtering is supposed to happen at another layer?

Created attachment 192986 [details]
Patch

(In reply to comment #2)
> (From update of attachment 192982 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192982&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Since webGLErrorsToConsoleEnabled is false durin layout tests, this change makes
> 
> durin -> during
> 
> > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:399
> > +        if (m_context->m_synthesizedErrorsToConsole)
> > +            m_context->printGLErrorToConsole(message);
> 
> Why isn't this needed in DRT?  Perhaps the filtering is supposed to happen at another layer?

For DRT, we use WebGraphicsContext3DInProcessImpl  which doesn't implement WebGraphicsContext3D::setErrorMessageCallback()

If we instead not invoke the error message callback in the out-of-process version used in content shell, the error messages also won't show up in the regular log which might make debugging of real errors in the future more difficult.

[Adam Barth]

Comment on attachment 192986 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 192986 [details]
Patch

Clearing flags on attachment: 192986

Committed r145761: <http://trac.webkit.org/changeset/145761>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.