Bug 11226

Summary: linux/gdk build fixes; fix memleaks; gdk improvements
Product: WebKit Reporter: Krzysztof Kowalczyk <kkowalczyk>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Description Flags
linux/gdk build fixes; minor gdk improvements ggaren: review+

Description Krzysztof Kowalczyk 2006-10-09 05:54:14 PDT
Fix linux/gdk build and minor gdk improvements.
Comment 1 Krzysztof Kowalczyk 2006-10-09 06:02:11 PDT
Created attachment 10991 [details]
linux/gdk build fixes; minor gdk improvements

Fix gdk build by adding missing PlatformScrollbar functions.

Improve gdk by:
* change compiler options to not use rtti and exceptions, which is the same thing that mac build is doing and results in significant savings in the size of stripped executable
* set warning to default (from off) and make sure debug info is generated.
* mark ~FrameGdk() as virtual, as it should be
* define SOURCE_ROOT in make-generated-sources.sh since it's used by one of the code generation scripts and without it make-generated-sources.sh fail for gdk build
* cleanup GdkLauncher\main.cpp formatting and add -exit-after-loading command-line option which causes the app to exit after fully loading and rendering a page. It's very useful for e.g. running automated memory leaks and profiling tests with valgrind
* fix 2 memory leaks (ImageCairo.cpp and FrameGkd.cpp) found by running valgrind
Comment 2 Geoffrey Garen 2006-10-09 16:04:02 PDT
Comment on attachment 10991 [details]
linux/gdk build fixes; minor gdk improvements

Comment 3 Mark Rowe (bdash) 2006-10-09 16:13:59 PDT
Landed in r16945.  Thanks Krzysztof!