Bug 112256

Summary:

Add touch support to the calendar picker

Product:

WebKit

Reporter:

Keishi Hattori <keishi>

Component:

Forms

Assignee:

Keishi Hattori <keishi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Keishi Hattori

Reported 2013-03-13 07:20:53 PDT

Add touch support to the calendar picker

Attachments
Patch (42.36 KB, patch) 2013-03-14 12:57 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (39.19 KB, patch) 2013-03-15 00:26 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (37.67 KB, patch) 2013-03-17 20:56 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (37.86 KB, patch) 2013-03-17 21:06 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Patch (38.20 KB, patch) 2013-03-18 03:32 PDT, Keishi Hattori	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Keishi Hattori

Comment 1 2013-03-14 12:57:28 PDT

Created attachment 193175 [details] Patch

WebKit Review Bot

Comment 2 2013-03-14 13:44:21 PDT

Comment on attachment 193175 [details] Patch Attachment 193175 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17214063 New failing tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html

Keishi Hattori

Comment 3 2013-03-15 00:26:48 PDT

Created attachment 193249 [details] Patch

Kent Tamura

Comment 4 2013-03-17 14:53:11 PDT

Comment on attachment 193249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193249&action=review > Source/WebCore/Resources/pagepopups/calendarPicker.js:1137 > +function FlingGestureAnimator(initialVelocity, initialValue) { Need a JsDoc comment > Source/WebCore/Resources/pagepopups/calendarPicker.js:1177 > +FlingGestureAnimator.P0 = -5707.62; > +FlingGestureAnimator.P1 = 0.172; > +FlingGestureAnimator.P2 = 0.0037; The names P0/P1/P2 are not descriptive. Please add comments or rename them. They should be private. > Source/WebCore/Resources/pagepopups/calendarPicker.js:3311 > + // you shouldn't be able to do gesture scroll. nit: y -> Y

Keishi Hattori

Comment 5 2013-03-17 20:56:55 PDT

Created attachment 193483 [details] Patch

Keishi Hattori

Comment 6 2013-03-17 21:06:41 PDT

Created attachment 193485 [details] Patch

WebKit Review Bot

Comment 7 2013-03-17 21:54:10 PDT

Comment on attachment 193485 [details] Patch Attachment 193485 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17129498 New failing tests: platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html

Keishi Hattori

Comment 8 2013-03-18 03:32:19 PDT

Created attachment 193517 [details] Patch

WebKit Review Bot

Comment 9 2013-03-18 04:04:50 PDT

Comment on attachment 193517 [details] Patch Clearing flags on attachment: 193517 Committed r146052: <http://trac.webkit.org/changeset/146052>

WebKit Review Bot

Comment 10 2013-03-18 04:04:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.