REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Nate Chapin]

Original report: https://code.google.com/p/chromium/issues/detail?id=177855

From the original bug:

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Ubuntu Chromium/24.0.1312.56 Chrome/24.0.1312.56 Safari/537.17

Example URL:
http://demo.sperke.net/postredirect.php

Steps to reproduce the problem:
1. Open the link
2. Click the submit button
3. Your request will be sent and you are redirected with header code 303 to the same url
4. Hit the reload button

What is the expected behavior?
The page should reload.

What went wrong?
Chrome asks for resubmitting the form. That is wrong because the last request was a get and no post request. The values should not be resent.

[Nate Chapin]

Created attachment 192820 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 192820 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192820&action=review

> Source/WebCore/loader/SubresourceLoader.cpp:135
> +    if (!redirectResponse.isNull()) {

How can SubresourceLoader::willSendRequest be called with a null redirectResponse? Could you please post a stack trace?

[Nate Chapin]

(In reply to comment #2)
> (From update of attachment 192820 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192820&action=review
> 
> > Source/WebCore/loader/SubresourceLoader.cpp:135
> > +    if (!redirectResponse.isNull()) {
> 
> How can SubresourceLoader::willSendRequest be called with a null redirectResponse? Could you please post a stack trace?

It's called for the initial request from ResourceLoader::init(). For example:

STDERR:  [0x0000008ec390] WebCore::SubresourceLoader::willSendRequest()
STDERR:  [0x0000008e6b17] WebCore::ResourceLoader::init()
STDERR:  [0x0000008ec1fa] WebCore::SubresourceLoader::init()
STDERR:  [0x0000008ec09f] WebCore::SubresourceLoader::create()
STDERR:  [0x000000c2aec8] WebCore::ResourceLoadScheduler::scheduleSubresourceLoad()
STDERR:  [0x000000908ba7] WebCore::CachedResource::load()
STDERR:  [0x000000915b02] WebCore::CachedResourceLoader::requestResource()
STDERR:  [0x000000914e72] WebCore::CachedResourceLoader::requestMainResource()
STDERR:  [0x0000008db8dc] WebCore::MainResourceLoader::load()
STDERR:  [0x0000008a5939] WebCore::DocumentLoader::startLoadingMainResource()

[Build Bot]

Comment on attachment 192820 [details]
patch

Attachment 192820 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17038416

[Nate Chapin]

Created attachment 192937 [details]
Checking build fix on EWS

[kov's GTK+ EWS bot]

Comment on attachment 192937 [details]
Checking build fix on EWS

Attachment 192937 [details] did not pass gtk-ews (gtk):
Output: http://webkit-commit-queue.appspot.com/results/17133064

[Build Bot]

Comment on attachment 192937 [details]
Checking build fix on EWS

Attachment 192937 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17178331

[Nate Chapin]

Created attachment 192944 [details]
another ews experiment

[Nate Chapin]

Created attachment 192955 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 192955 [details]
Patch for landing

Clearing flags on attachment: 192955

Committed r145735: <http://trac.webkit.org/changeset/145735>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.