Bug 112188

Summary: Cleanup: Move timeline_exporer js out of html file into js.
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Julie Parent
Reported 2013-03-12 14:19:30 PDT
Cleanup: Move timeline_exporer js out of html file into js.
Attachments
Patch (39.79 KB, patch)
2013-03-12 14:43 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch (39.99 KB, patch)
2013-03-14 17:59 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julie Parent
Comment 1 2013-03-12 14:43:45 PDT
Created attachment 192808 [details] Patch
Julie Parent
Comment 2 2013-03-14 17:59:08 PDT
Created attachment 193211 [details] Patch Uploaded since loader move. Ready for review.
Julie Parent
Comment 3 2013-03-18 11:34:10 PDT
Can someone take a look at this? Just a simple cleanup of moving the timeline explorer's javascript out of the html file and into its own js file, and moving a few functions from dashboard_base that are only used by timeline explorer into that file too.
Dirk Pranke
Comment 4 2013-03-18 12:10:44 PDT
Comment on attachment 193211 [details] Patch No test files needed to change to include the new js file?
Julie Parent
Comment 5 2013-03-18 12:43:01 PDT
(In reply to comment #4) > (From update of attachment 193211 [details]) > No test files needed to change to include the new js file? Nope, none of the code in the new file could have been tested before, since it was just inline in the html page. Now that it is in its own js file, we can start actually testing it, modularizing, etc.
WebKit Review Bot
Comment 6 2013-03-18 12:58:34 PDT
Comment on attachment 193211 [details] Patch Clearing flags on attachment: 193211 Committed r146106: <http://trac.webkit.org/changeset/146106>
WebKit Review Bot
Comment 7 2013-03-18 12:58:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.