Bug 112184

Summary: [EFL] Better error handling in NetworkStateNotifierEfl
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
eflews.bot: commit-queue-
Patch
kenneth: review+
Patch for landing none

Description Chris Dumez 2013-03-12 13:33:05 PDT
Error handling should be improved in the NETLINK socket code in NetworkStateNotifierEfl.
Comment 1 Chris Dumez 2013-03-12 14:12:30 PDT
Created attachment 192804 [details]
Patch
Comment 2 Chris Dumez 2013-03-12 14:20:00 PDT
Created attachment 192806 [details]
Patch
Comment 3 EFL EWS Bot 2013-03-12 17:18:34 PDT
Comment on attachment 192806 [details]
Patch

Attachment 192806 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17189283
Comment 4 EFL EWS Bot 2013-03-12 17:51:24 PDT
Comment on attachment 192806 [details]
Patch

Attachment 192806 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17201139
Comment 5 Chris Dumez 2013-03-12 23:33:52 PDT
Created attachment 192873 [details]
Patch

Fix release build.
Comment 6 Kenneth Rohde Christiansen 2013-03-13 09:08:56 PDT
Comment on attachment 192873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192873&action=review

> Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:112
> +    while (1) {

isnt while (true) not more readable?

> Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:113
> +        ssize_t len = recv(sock, nlh, bufferSize, MSG_DONTWAIT);

length?
Comment 7 Chris Dumez 2013-03-13 12:37:23 PDT
Created attachment 192965 [details]
Patch for landing

Fixed nits.
Comment 8 WebKit Review Bot 2013-03-13 13:12:20 PDT
Comment on attachment 192965 [details]
Patch for landing

Clearing flags on attachment: 192965

Committed r145741: <http://trac.webkit.org/changeset/145741>
Comment 9 WebKit Review Bot 2013-03-13 13:12:25 PDT
All reviewed patches have been landed.  Closing bug.