Summary: | [EFL] Better error handling in NetworkStateNotifierEfl | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2013-03-12 13:33:05 PDT
Created attachment 192804 [details]
Patch
Created attachment 192806 [details]
Patch
Comment on attachment 192806 [details] Patch Attachment 192806 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17189283 Comment on attachment 192806 [details] Patch Attachment 192806 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17201139 Created attachment 192873 [details]
Patch
Fix release build.
Comment on attachment 192873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192873&action=review > Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:112 > + while (1) { isnt while (true) not more readable? > Source/WebCore/platform/network/efl/NetworkStateNotifierEfl.cpp:113 > + ssize_t len = recv(sock, nlh, bufferSize, MSG_DONTWAIT); length? Created attachment 192965 [details]
Patch for landing
Fixed nits.
Comment on attachment 192965 [details] Patch for landing Clearing flags on attachment: 192965 Committed r145741: <http://trac.webkit.org/changeset/145741> All reviewed patches have been landed. Closing bug. |