Bug 112171

Summary:

Moved RunLoopTimer and SchedulePair to WTF

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, ddkilzer, japhet, ojan.autocc, simon.fraser, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	oliver: review+

Geoffrey Garen

Reported 2013-03-12 11:12:51 PDT

Moved RunLoopTimer and SchedulePair to WTF

Attachments
Patch (76.81 KB, patch) 2013-03-12 11:16 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (80.87 KB, patch) 2013-03-12 11:29 PDT, Geoffrey Garen	no flags	Details Formatted Diff Diff
Patch (82.53 KB, patch) 2013-03-12 12:56 PDT, Geoffrey Garen	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Geoffrey Garen

Comment 1 2013-03-12 11:16:19 PDT

Created attachment 192773 [details] Patch

WebKit Review Bot

Comment 2 2013-03-12 11:19:50 PDT

Attachment 192773 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1 Source/WTF/wtf/RunLoopTimer.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/RunLoopTimerCF.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 2 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2013-03-12 11:24:35 PDT

Comment on attachment 192773 [details] Patch Attachment 192773 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17196061

EFL EWS Bot

Comment 4 2013-03-12 11:26:38 PDT

Comment on attachment 192773 [details] Patch Attachment 192773 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17174102

Geoffrey Garen

Comment 5 2013-03-12 11:29:24 PDT

Created attachment 192776 [details] Patch

WebKit Review Bot

Comment 6 2013-03-12 11:31:36 PDT

Attachment 192776 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/wince/IconDatabaseWinCE.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopCF.cpp', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1 Source/WTF/wtf/RunLoopTimer.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/RunLoopTimerCF.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 2 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mark Lam

Comment 7 2013-03-12 11:36:47 PDT

Comment on attachment 192776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192776&action=review > Source/WTF/wtf/AutodrainedPool.h:2 > + * Copyright (C) 2007 Apple Inc. All rights reserved. Drive by comment: update copyright headers? Same for other moved files.

Geoffrey Garen

Comment 8 2013-03-12 12:56:46 PDT

Created attachment 192791 [details] Patch

Geoffrey Garen

Comment 9 2013-03-12 12:57:30 PDT

Updated copyright in moved files.

WebKit Review Bot

Comment 10 2013-03-12 13:00:59 PDT

Attachment 192791 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/AutodrainedPool.h', u'Source/WTF/wtf/AutodrainedPoolMac.mm', u'Source/WTF/wtf/RunLoopTimer.h', u'Source/WTF/wtf/RunLoopTimerCF.cpp', u'Source/WTF/wtf/SchedulePair.cpp', u'Source/WTF/wtf/SchedulePair.h', u'Source/WTF/wtf/SchedulePairMac.mm', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseThread.cpp', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/fileapi/FileThread.cpp', u'Source/WebCore/loader/DocumentLoader.h', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/icon/IconDatabase.cpp', u'Source/WebCore/loader/icon/wince/IconDatabaseWinCE.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/platform/AutodrainedPool.h', u'Source/WebCore/platform/cf/RunLoopCF.cpp', u'Source/WebCore/platform/cf/RunLoopTimerCF.cpp', u'Source/WebCore/platform/cf/SchedulePair.cpp', u'Source/WebCore/platform/cf/SchedulePair.h', u'Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp', u'Source/WebCore/platform/mac/AutodrainedPool.mm', u'Source/WebCore/platform/mac/SchedulePairMac.mm', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp', u'Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebCore/storage/StorageThread.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h']" exit_code: 1 Source/WTF/wtf/RunLoopTimer.h:32: Alphabetical sorting problem. [build/include_order] [4] Source/WTF/wtf/RunLoopTimerCF.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 2 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Oliver Hunt

Comment 11 2013-03-12 14:52:06 PDT

Comment on attachment 192791 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192791&action=review r=me, fix style issues before landing, and watch the windows bot >> Source/WTF/wtf/RunLoopTimer.h:32 >> +#include <wtf/SchedulePair.h> > > Alphabetical sorting problem. [build/include_order] [4] Please to be fixing this :D

Geoffrey Garen

Comment 12 2013-03-12 15:06:10 PDT

Committed r145592: <http://trac.webkit.org/changeset/145592>

David Kilzer (:ddkilzer)

Comment 13 2013-03-17 13:15:14 PDT

(In reply to comment #12) > Committed r145592: <http://trac.webkit.org/changeset/145592> Build fix: http://trac.webkit.org/changeset/146023

Note You need to log in before you can comment on or make changes to this bug.