Bug 11214

Summary: http/tests/xmlhttprequest/exceptions.html needs new results
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: annevk, ap, aroben
Priority: P2 Keywords: EasyFix
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://build.webkit.org/results/post-commit-powerpc-mac-os-x/3700/http/tests/xmlhttprequest/exceptions-diffs.txt
Attachments:
Description Flags
New results
none
Updated with comment as to why "FAIL" is the expected output
darin: review+
Updated w/ better comment, removed "FAIL" from expected output adele: review+

Adam Roben (:aroben)
Reported 2006-10-08 02:22:40 PDT
Change r16794 broke this test, and it needs new results.
Attachments
New results (1.65 KB, patch)
2006-10-08 02:23 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Updated with comment as to why "FAIL" is the expected output (2.85 KB, patch)
2006-10-08 03:16 PDT, Adam Roben (:aroben) 		darin: review+
DetailsFormatted DiffDiff
Updated w/ better comment, removed "FAIL" from expected output (3.16 KB, patch)
2006-10-15 11:57 PDT, Adam Roben (:aroben) 		adele: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2006-10-08 02:23:22 PDT
Created attachment 10974 [details] New results
Adam Roben (:aroben)
Comment 2 2006-10-08 03:16:55 PDT
Created attachment 10975 [details] Updated with comment as to why "FAIL" is the expected output Mitz suggested I add a comment explaining why "FAIL" is expected behavior for two tests.
Darin Adler
Comment 3 2006-10-08 07:01:47 PDT
Comment on attachment 10975 [details] Updated with comment as to why "FAIL" is the expected output r=me
Darin Adler
Comment 4 2006-10-08 07:03:02 PDT
The comment is not so great for people who don't have access to Radar. It would be better to write a comment that explains the reason a tiny bit (many Dashboard widgets will fail if we change the behavior).
Adam Roben (:aroben)
Comment 5 2006-10-15 11:57:44 PDT
Created attachment 11098 [details] Updated w/ better comment, removed "FAIL" from expected output Hyatt and Mitz felt that we should not have "FAIL" in our expected results, so I've changed the test to remove this output. I also have cleared up the comments in the test per Darin's request.
Adam Roben (:aroben)
Comment 6 2006-10-17 09:41:52 PDT
Landed as r17078
Note You need to log in before you can comment on or make changes to this bug.