Bug 112105

Summary:

Web Inspector: Better layout for Styles tab

Product:

WebKit

Reporter:

Vladislav Kaznacheev <kaznacheev>

Component:

Web Inspector (Deprecated)

Assignee:

Vladislav Kaznacheev <kaznacheev>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Suggested UI	none
Patch	none
Patch	none
Updated UI sample: regular view	none
Updated UI sample: expanded element state drawer	none
Patch	pfeldman: review-

Vladislav Kaznacheev

Reported 2013-03-11 23:18:37 PDT

The recently added Styles tab combines Styles, Metrics and Computed Style panes. The Styles toolbar is positioned awkwardly on top of the Styles pane and partially obscures the drawer showing up on "Toggle Element State". Suggested solution: push the styles pane one line lower and add a toolbar with standard sidebar title bar with "Matched Rules" text

Attachments
Suggested UI (132.66 KB, image/png) 2013-03-11 23:19 PDT, Vladislav Kaznacheev	no flags	Details
Patch (6.86 KB, patch) 2013-03-11 23:24 PDT, Vladislav Kaznacheev	no flags	Details Formatted Diff Diff
Patch (6.94 KB, patch) 2013-03-12 03:12 PDT, Vladislav Kaznacheev	no flags	Details Formatted Diff Diff
Updated UI sample: regular view (111.56 KB, image/png) 2013-03-12 03:13 PDT, Vladislav Kaznacheev	no flags	Details
Updated UI sample: expanded element state drawer (110.15 KB, image/png) 2013-03-12 03:13 PDT, Vladislav Kaznacheev	no flags	Details
Patch (4.47 KB, patch) 2013-03-19 02:24 PDT, Vladislav Kaznacheev	pfeldman: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Vladislav Kaznacheev

Comment 1 2013-03-11 23:19:31 PDT

Created attachment 192650 [details] Suggested UI

Vladislav Kaznacheev

Comment 2 2013-03-11 23:24:15 PDT

Created attachment 192651 [details] Patch

Vladislav Kaznacheev

Comment 3 2013-03-12 03:12:27 PDT

Created attachment 192690 [details] Patch

Vladislav Kaznacheev

Comment 4 2013-03-12 03:13:03 PDT

Created attachment 192691 [details] Updated UI sample: regular view

Vladislav Kaznacheev

Comment 5 2013-03-12 03:13:39 PDT

Created attachment 192692 [details] Updated UI sample: expanded element state drawer

Build Bot

Comment 6 2013-03-12 11:00:22 PDT

Comment on attachment 192690 [details] Patch Attachment 192690 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17115349 New failing tests: editing/selection/selection-modify-crash.html

Vladislav Kaznacheev

Comment 7 2013-03-19 02:24:33 PDT

Created attachment 193768 [details] Patch

Vladislav Kaznacheev

Comment 8 2013-03-19 02:25:07 PDT

Abandoning the change.

Pavel Feldman

Comment 9 2013-03-19 09:48:28 PDT

Comment on attachment 193768 [details] Patch Holding off as agreed offline.

Note You need to log in before you can comment on or make changes to this bug.