Bug 112090

Summary:

[Mac][WK1] Add support for alert() in MiniBrowser.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Tools / Tests

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, kling, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+
Patch for landing	none

Description Andreas Kling 2013-03-11 18:32:56 PDT

>be me
>make simple test page to dump smth from js
>open page in minibrowser to check if behavior differs between WK1/WK2
>mfw alert() is a no-op

Comment 1 Andreas Kling 2013-03-11 18:36:18 PDT

Created attachment 192616 [details]
Patch

Comment 2 Andreas Kling 2013-03-11 18:38:08 PDT

Created attachment 192617 [details]
Patch

Comment 3 Andreas Kling 2013-03-11 18:56:50 PDT

Created attachment 192623 [details]
Patch for landing

Comment 4 WebKit Review Bot 2013-03-11 19:40:14 PDT

Comment on attachment 192623 [details]
Patch for landing

Clearing flags on attachment: 192623

Committed r145468: <http://trac.webkit.org/changeset/145468>

Comment 5 WebKit Review Bot 2013-03-11 19:40:17 PDT

All reviewed patches have been landed.  Closing bug.