Bug 112051

Summary: Crash in DumpRenderTree at com.apple.WebCore: WebCore::CaptionUserPreferences::captionPreferencesChanged + 185
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dino, eric.carlson, esprehn+autocc, feature-media-reviews, jer.noble, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2 Keywords: InRadar, MakingBotsRed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2013-03-11 12:45:55 PDT
Crash in DumpRenderTree at com.apple.WebCore: WebCore::CaptionUserPreferences::captionPreferencesChanged + 185
Attachments
Patch (20.76 KB, patch)
2013-03-13 11:27 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-03-11 12:46:26 PDT
Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000010b4521a9 WebCore::CaptionUserPreferences::captionPreferencesChanged() + 185 (CaptionUserPreferences.cpp:62) 1 com.apple.WebCore 0x000000010b4520df WebCore::CaptionUserPreferences::setUserPrefersCaptions(bool) + 63 (CaptionUserPreferences.cpp:54) 2 com.apple.WebCore 0x000000010a40dfac WebCore::HTMLMediaElement::toggleTrackAtIndex(int, bool) + 252 (HTMLMediaElement.cpp:3128) 3 com.apple.WebCore 0x000000010acbc59e WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler(WebCore::Event*) + 238 (MediaControlElements.cpp:765) 4 com.apple.WebCore 0x000000010a12b3ca WebCore::EventDispatcher::dispatchEventPostProcess(WTF::PassRefPtr<WebCore::Event>, void*) + 586 (EventDispatcher.cpp:230) 5 com.apple.WebCore 0x000000010a12a7e8 WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) + 1032 (EventDispatcher.cpp:135) 6 com.apple.WebCore 0x000000010ad23c4d WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const + 685 (MouseEvent.cpp:280) 7 com.apple.WebCore 0x000000010a129c89 WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WTF::PassRefPtr<WebCore::EventDispatchMediator>) + 169 (EventDispatcher.cpp:55) 8 com.apple.WebCore 0x000000010ad59440 WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*) + 176 (Node.cpp:2371) 9 com.apple.WebCore 0x000000010a136ad4 WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool) + 212 (EventHandler.cpp:2235) 10 com.apple.WebCore 0x000000010a1390d5 WebCore::EventHandler::handleMouseReleaseEvent(WebCore::PlatformMouseEvent const&) + 1381 (EventHandler.cpp:1848) 11 com.apple.WebCore 0x000000010a147be4 WebCore::EventHandler::mouseUp(NSEvent*) + 340 (EventHandlerMac.mm:514) 12 com.apple.WebKit 0x00000001094972e8 -[WebHTMLView mouseUp:] + 344 (WebHTMLView.mm:3760) 13 DumpRenderTree 0x00000001080472a9 -[EventSendingController mouseUp:withModifiers:] + 1065 (EventSendingController.mm:426) 14 com.apple.CoreFoundation 0x00007fff8e07663c __invoking___ + 140 15 com.apple.CoreFoundation 0x00007fff8e0764d7 -[NSInvocation invoke] + 263 16 DumpRenderTree 0x0000000108048353 +[EventSendingController replaySavedEvents] + 195 (EventSendingController.mm:579) 17 DumpRenderTree 0x0000000108046fee -[EventSendingController mouseUp:withModifiers:] + 366 (EventSendingController.mm:404) 18 com.apple.CoreFoundation 0x00007fff8e07663c __invoking___ + 140 19 com.apple.CoreFoundation 0x00007fff8e0764d7 -[NSInvocation invoke] + 263 20 com.apple.WebCore 0x000000010ad8bf93 JSC::Bindings::ObjcInstance::invokeObjcMethod(JSC::ExecState*, JSC::Bindings::ObjcMethod*) + 1923 (objc_instance.mm:320) 21 com.apple.WebCore 0x000000010ad8b7f0 JSC::Bindings::ObjcInstance::invokeMethod(JSC::ExecState*, JSC::RuntimeMethod*) + 304 (objc_instance.mm:232) 22 com.apple.WebCore 0x000000010b1886d2 JSC::callRuntimeMethod(JSC::ExecState*) + 530 (runtime_method.cpp:115) 23 com.apple.JavaScriptCore 0x000000010853d7b9 JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) + 329 (LLIntSlowPaths.cpp:1364) 24 com.apple.JavaScriptCore 0x000000010853e6dc JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) + 92 (LLIntSlowPaths.cpp:1408) 25 com.apple.JavaScriptCore 0x000000010853e666 JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind) + 246 (LLIntSlowPaths.cpp:1464) 26 com.apple.JavaScriptCore 0x000000010853b75c llint_slow_path_call + 60 (LLIntSlowPaths.cpp:1470) 27 com.apple.JavaScriptCore 0x0000000108544352 llint_op_call + 184 28 com.apple.JavaScriptCore 0x0000000108421544 JSC::JITCode::execute(JSC::JSStack*, JSC::ExecState*, JSC::JSGlobalData*) + 84 (JITCode.h:135) 29 com.apple.JavaScriptCore 0x000000010841e7bf JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 1519 (Interpreter.cpp:1055) 30 com.apple.JavaScriptCore 0x00000001082310c2 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 306 (CallData.cpp:40) 31 com.apple.WebCore 0x000000010a6b0582 WebCore::JSMainThreadExecState::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) + 146 (JSMainThreadExecState.h:56) 32 com.apple.WebCore 0x000000010b194f7f WebCore::ScheduledAction::executeFunctionInContext(JSC::JSGlobalObject*, JSC::JSValue, WebCore::ScriptExecutionContext*) + 559 (ScheduledAction.cpp:112) 33 com.apple.WebCore 0x000000010b194b43 WebCore::ScheduledAction::execute(WebCore::Document*) + 323 (ScheduledAction.cpp:134) 34 com.apple.WebCore 0x000000010b194984 WebCore::ScheduledAction::execute(WebCore::ScriptExecutionContext*) + 116 (ScheduledAction.cpp:80) 35 com.apple.WebCore 0x000000010a0947aa WebCore::DOMTimer::fired() + 538 (DOMTimer.cpp:141) 36 com.apple.WebCore 0x000000010b52bade WebCore::ThreadTimers::sharedTimerFiredInternal() + 302 (ThreadTimers.cpp:132) 37 com.apple.WebCore 0x000000010b52b7f9 WebCore::ThreadTimers::sharedTimerFired() + 25 (ThreadTimers.cpp:106) 38 com.apple.WebCore 0x000000010b25bbf3 WebCore::timerFired(__CFRunLoopTimer*, void*) + 67 (SharedTimerMac.mm:167) 39 com.apple.CoreFoundation 0x00007fff8e03fda4 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 40 com.apple.CoreFoundation 0x00007fff8e03f8bd __CFRunLoopDoTimer + 557 41 com.apple.CoreFoundation 0x00007fff8e025099 __CFRunLoopRun + 1513 42 com.apple.CoreFoundation 0x00007fff8e0246b2 CFRunLoopRunSpecific + 290 43 com.apple.Foundation 0x00007fff8904289e -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 268 44 DumpRenderTree 0x000000010803ab29 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 5017 (DumpRenderTree.mm:1374) 45 DumpRenderTree 0x000000010803971a runTestingServerLoop() + 282 (DumpRenderTree.mm:832) 46 DumpRenderTree 0x0000000108039115 dumpRenderTree(int, char const**) + 405 (DumpRenderTree.mm:887) 47 DumpRenderTree 0x000000010803b319 main + 105 (DumpRenderTree.mm:925) 48 libdyld.dylib 0x00007fff8b77e7e1 start + 1
Jer Noble
Comment 2 2013-03-11 12:46:57 PDT
<rdar://problem/13367999>
Simon Fraser (smfr)
Comment 3 2013-03-12 18:07:26 PDT
CRASHING TEST: media/video-controls-captions-trackmenu.html
Jer Noble
Comment 4 2013-03-13 11:27:58 PDT
Created attachment 192952 [details] Patch
Eric Carlson
Comment 5 2013-03-14 10:16:18 PDT
Comment on attachment 192952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192952&action=review > Source/WebCore/page/CaptionUserPreferences.cpp:33 > +#include "Page.h" > +#include "PageCache.h" > +#include "PageGroup.h" Do we really need all three of these?
Jer Noble
Comment 6 2013-03-14 10:24:17 PDT
Comment on attachment 192952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192952&action=review >> Source/WebCore/page/CaptionUserPreferences.cpp:33 >> +#include "PageGroup.h" > > Do we really need all three of these? Whoops, no, just PageCache.h. (CaptionUserPreferences::captionPreferencesChanged() used to do all the work in PageGroup::captionPreferencesChanged(), which is why they were there in the first place.) Removed the unnecessary #includes.
Jer Noble
Comment 7 2013-03-14 10:29:33 PDT
Committed r145826: <http://trac.webkit.org/changeset/145826>
Note You need to log in before you can comment on or make changes to this bug.