Bug 112011

Summary: Web Inspector: add per image statistics to the native memory snapshot
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+, yurys: commit-queue-

Description Yury Semikhatsky 2013-03-11 08:03:11 PDT
We can display url->retained size for each CachedImage under Images section in the "native memory distribution" table.
Comment 1 Yury Semikhatsky 2013-03-11 08:05:48 PDT
Created attachment 192472 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-03-11 08:14:30 PDT
Comment on attachment 192472 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192472&action=review

I'd extract proxyConstructor part of the patch into a separate patch

> Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186
> +    this._worker = typeof InspectorTest !== "undefined" ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker();

please remove this
Comment 3 Yury Semikhatsky 2013-03-11 08:46:05 PDT
(In reply to comment #2)
> > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:186
> > +    this._worker = typeof InspectorTest !== "undefined" ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker();
> 
> please remove this

Done.
Comment 4 Yury Semikhatsky 2013-03-11 08:49:57 PDT
Committed r145367: <http://trac.webkit.org/changeset/145367>