Summary: | WebKit doesn't configure if gtk-doc-am is not installed Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tobias Mueller <tobiasmue> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | csaavedra, mrobinson, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tobias Mueller
2013-03-11 05:52:59 PDT
Created attachment 192453 [details]
Sets ENABLE_GTK_DOC if GTK_DOC_CHECK is not found
Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html When you do, please flip the review and commit-queue flags to '?'. Thank you! Where does GTK_DOC_CHECK come from in this case? It comes from gtkdoc.m4. (In reply to comment #4) > It comes from gtkdoc.m4. Ah! This patch makes sense to me now. :) Created attachment 192517 [details] Same path with a changelog entry (In reply to comment #2) > Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html k. I didn't do in first place because I came from http://webkitgtk.org/?page=contribute which does not reference the website you pointed out. > When you do, please flip the review and commit-queue flags to '?'. Thank you! k. Comment on attachment 192517 [details] Same path with a changelog entry Clearing flags on attachment: 192517 Committed r145427: <http://trac.webkit.org/changeset/145427> All reviewed patches have been landed. Closing bug. |