Bug 111980 – WebKit doesn't configure if gtk-doc-am is not installed Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Tobias Mueller]

$ ./autogen.sh --prefix /opt/gnome2 --libdir /opt/gnome2/lib64 --enable-introspection --disable-silent-rules --with-gstreamer=1.0 --disable-static --disable-scrollkeeper --disable-gtk-doc --disable-docs --enable-gtk-doc=no --enable-gtk-doc-html=no --enable-gtk-doc-pdf=no --disable-webkit1 --disable-spellcheck --disable-glx --disable-egl --disable-gles2 --disable-gamepad --disable-video --disable-mediastream --enable-xslt --disable-geolocation --disable-svg --disable-svg-fonts --disable-web-audio --disable-coverage --disable-webgl --disable-gtk-doc-html --disable-accelerated-compositing
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I Source/autotools 
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy
libtoolize: Remember to add `LT_INIT' to configure.ac.
libtoolize: Consider adding `-I Source/autotools' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: running: /usr/bin/autoconf --include=Source/autotools
autoreconf: running: /usr/bin/autoheader --include=Source/autotools
autoreconf: running: automake --add-missing --copy --no-force
Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
GNUmakefile.am:183:   `Tools/GNUmakefile.am' included from here
autoreconf: automake failed with exit status: 1
$  automake --add-missing --copy --no-force
Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
GNUmakefile.am:183:   `Tools/GNUmakefile.am' included from here
$  echo $?
1
$ automake --version
automake (GNU automake) 1.11.6
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later <http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <[e-mail]>
       and Alexandre Duret-Lutz <[e-mail]>.

$ automake --add-missing --copy --no-force -v
automake: thread 0: reading autoconf --trace=_LT_AC_TAGCONFIG:\$f:\$l::\$d::\$n::\${::}% --trace=AC_INIT:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_IF:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_TARGET:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_LIBOBJ_DIR:\$f:\$l::\$d::\$n::\${::}% --trace=AC_FC_SRCEXT:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_HOST:\$f:\$l::\$d::\$n::\${::}% --trace=AM_INIT_AUTOMAKE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_AUTOMAKE_VERSION:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_LINKS:\$f:\$l::\$d::\$n::\${::}% --trace=AC_REQUIRE_AUX_FILE:\$f:\$l::\$d::\$n::\${::}% --trace=m4_sinclude:\$f:\$l::\$d::\$n::\${::}% --trace=LT_SUPPORTED_TAG:\$f:\$l::\$d::\$n::\${::}% --trace=AM_MAINTAINER_MODE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_GNU_GETTEXT_INTL_SUBDIR:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_ENDIF:\$f:\$l::\$d::\$n::\${::}% --trace=AM_ENABLE_MULTILIB:\$f:\$l::\$d::\$n::\${::}% --trace=AM_SILENT_RULES:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_FILES:\$f:\$l::\$d::\$n::\${::}% --trace=AM_GNU_GETTEXT:\$f:\$l::\$d::\$n::\${::}% --trace=AM_PROG_AR:\$f:\$l::\$d::\$n::\${::}% --trace=AC_LIBSOURCE:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CANONICAL_BUILD:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_AUX_DIR:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_SUBST_NOTMAKE:\$f:\$l::\$d::\$n::\${::}% --trace=AM_PROG_CC_C_O:\$f:\$l::\$d::\$n::\${::}% --trace=sinclude:\$f:\$l::\$d::\$n::\${::}% --trace=AM_CONDITIONAL:\$f:\$l::\$d::\$n::\${::}% --trace=AC_CONFIG_HEADERS:\$f:\$l::\$d::\$n::\${::}% --trace=m4_include:\$f:\$l::\$d::\$n::\${::}% --trace=_AM_COND_ELSE:\$f:\$l::\$d::\$n::\${::}% --trace=AC_SUBST_TRACE:\$f:\$l::\$d::\$n::\${::}%
automake: thread 0: reading /usr/share/automake-1.11/am/header-vars.am
automake: thread 0: reading GNUmakefile.am
automake: thread 0: reading Source/WTF/GNUmakefile.am
automake: thread 0: reading Source/WTF/GNUmakefile.list.am
automake: thread 0: reading Source/JavaScriptCore/GNUmakefile.am
automake: thread 0: reading Source/JavaScriptCore/GNUmakefile.list.am
automake: thread 0: reading Source/WebCore/GNUmakefile.am
automake: thread 0: reading Source/WebCore/GNUmakefile.list.am
automake: thread 0: reading Source/WebCore/bindings/gobject/GNUmakefile.am
automake: thread 0: reading Source/WebCore/platform/gtk/po/GNUmakefile.am
automake: thread 0: Sources ending in .po become .mo
automake: thread 0: Sources ending in .nop become .po-create
automake: thread 0: reading Source/WebKit/gtk/GNUmakefile.am
automake: thread 0: reading Tools/GNUmakefile.am
Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL
GNUmakefile.am:183:   `Tools/GNUmakefile.am' included from here
automake: thread 0: reading Source/WebKit2/GNUmakefile.am
automake: thread 0: reading Source/WebKit2/GNUmakefile.list.am
automake: thread 0: reading Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
automake: thread 0: reading Tools/MiniBrowser/gtk/GNUmakefile.am
automake: thread 0: reading Tools/WebKitTestRunner/GNUmakefile.am
automake: thread 0: reading Source/ThirdParty/gtest/GNUmakefile.am
automake: thread 0: reading Tools/TestWebKitAPI/GNUmakefile.am
automake: thread 0: reading /usr/share/automake-1.11/am/configure.am
automake: thread 0: reading /usr/share/automake-1.11/am/remake-hdr.am
automake: thread 0: reading /usr/share/automake-1.11/am/clean-hdr.am
automake: thread 0: reading /usr/share/automake-1.11/am/ltlib.am
automake: thread 0: reading /usr/share/automake-1.11/am/inst-vars.am
automake: thread 0: reading /usr/share/automake-1.11/am/ltlibrary.am
automake: thread 0: reading /usr/share/automake-1.11/am/progs.am
automake: thread 0: reading /usr/share/automake-1.11/am/program.am
automake: thread 0: reading /usr/share/automake-1.11/am/compile.am
automake: thread 0: reading /usr/share/automake-1.11/am/depend.am
automake: thread 0: reading /usr/share/automake-1.11/am/depend2.am
automake: thread 0: Sources ending in .c become .o
automake: thread 0: Sources ending in .c become .obj
automake: thread 0: Sources ending in .c become .lo
automake: thread 0: reading /usr/share/automake-1.11/am/lang-compile.am
automake: thread 0: Sources ending in .cc become .o
automake: thread 0: Sources ending in .cc become .obj
automake: thread 0: Sources ending in .cc become .lo
automake: thread 0: Sources ending in .cpp become .o
automake: thread 0: Sources ending in .cpp become .obj
automake: thread 0: Sources ending in .cpp become .lo
automake: thread 0: reading /usr/share/automake-1.11/am/libtool.am
automake: thread 0: reading /usr/share/automake-1.11/am/texinfos.am
automake: thread 0: reading /usr/share/automake-1.11/am/data.am
automake: thread 0: reading /usr/share/automake-1.11/am/header.am
automake: thread 0: reading /usr/share/automake-1.11/am/tags.am
automake: thread 0: reading /usr/share/automake-1.11/am/distdir.am
automake: thread 0: reading /usr/share/automake-1.11/am/footer.am
automake: thread 0: reading /usr/share/automake-1.11/am/install.am
automake: thread 0: reading /usr/share/automake-1.11/am/clean.am
automake: thread 0: not writing ./GNUmakefile.in because of earlier errors




Looking at https://developer.gnome.org/gtk-doc-manual/unstable/settingup_autoconf.html.en the correct fix seems to be to check whether the GTK_DOC_CHECK macro exists and if not, set ENABLE_GTK_DOC to false.

After applying the patch attached, I could run the ./autogen.sh

[Tobias Mueller]

Created attachment 192453 [details]
Sets ENABLE_GTK_DOC if GTK_DOC_CHECK is not found

[Claudio Saavedra]

Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html When you do, please flip the review and commit-queue flags to '?'. Thank you!

[Martin Robinson]

Where does GTK_DOC_CHECK come from in this case?

[Claudio Saavedra]

It comes from gtkdoc.m4.

[Martin Robinson]

(In reply to comment #4)
> It comes from gtkdoc.m4.

Ah! This patch makes sense to me now. :)

[Tobias Mueller]

Created attachment 192517 [details]
Same path with a changelog entry

(In reply to comment #2)
> Thanks for the patch! Would you mind adding a ChangeLog entry as described here? https://www.webkit.org/coding/contributing.html

k. I didn't do in first place because I came from http://webkitgtk.org/?page=contribute which does not reference the website you pointed out.

> When you do, please flip the review and commit-queue flags to '?'. Thank you!
k.

[WebKit Review Bot]

Comment on attachment 192517 [details]
Same path with a changelog entry

Clearing flags on attachment: 192517

Committed r145427: <http://trac.webkit.org/changeset/145427>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.