Bug 111973

Summary: [GTK][WK2] REGRESSION(r145081): Unit tests not working if locale is not English
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2013-03-11 04:40:56 PDT
Since we added support for localization in WebKit2GTK+ the unit tests didn't work if you are not using English locale.
Attachments
Patch (1.43 KB, patch)
2013-03-11 04:44 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (1.92 KB, patch)
2013-03-11 10:28 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2013-03-11 04:44:20 PDT
Created attachment 192439 [details] Patch
WebKit Review Bot
Comment 2 2013-03-11 04:46:54 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2013-03-11 05:19:30 PDT
Comment on attachment 192439 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192439&action=review LGTM, thanks! > Source/WebKit2/ChangeLog:8 > + Fix unit tests setting the environment variable LC_ALL to C. Please explain here that the problem is that the web process doesn't inherit the locale set in the UI process and uses the system one. In the UI process gtk_test_init call setlocale to reset the locale, but that's not inherited by the web process and we end up with a different locale used by UI and web processes. This is only a problem in some of the tests like the context menu and printing one where we compare strings from both processes.
Manuel Rego Casasnovas
Comment 4 2013-03-11 10:28:05 PDT
Created attachment 192499 [details] Patch Upload new version with a better ChangeLog explaining the problem and the solution.
Carlos Garcia Campos
Comment 5 2013-03-12 03:00:01 PDT
Comment on attachment 192499 [details] Patch Thanks!
WebKit Review Bot
Comment 6 2013-03-12 03:09:46 PDT
Comment on attachment 192499 [details] Patch Clearing flags on attachment: 192499 Committed r145508: <http://trac.webkit.org/changeset/145508>
WebKit Review Bot
Comment 7 2013-03-12 03:09:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.