Summary: | SVGDocumentExtensions should use OwnPtr for pending resource maps. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | SVG | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, d-r, fmalita, krit, pdr, peter+ews, rego+ews, schenney, webkit-ews, webkit.review.bot, xan.lopez, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2013-03-10 10:50:42 PDT
Created attachment 192381 [details]
Patch
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17024104 Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17163030 Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17124081 Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17162025 Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17017862 I would like to ask you t wait till one of the SVG folks 2nd the patch before landing. thanks. Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17131094 Except for the compile error, this looks good. I've been meaning to make the same change for some time :) Created attachment 192384 [details]
Patch for landing
Fixed the 0/nullptr build failure. Anders also requested that I use HashMap::AddResult instead of the awkward ValueType& foo = add().iterator->value; idiom.
Comment on attachment 192384 [details] Patch for landing Clearing flags on attachment: 192384 Committed r145333: <http://trac.webkit.org/changeset/145333> All reviewed patches have been landed. Closing bug. |