Bug 111943

Summary: SVGDocumentExtensions should use OwnPtr for pending resource maps.
Product: WebKit Reporter: Andreas Kling <kling>
Component: SVGAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, d-r, fmalita, krit, pdr, peter+ews, rego+ews, schenney, webkit-ews, webkit.review.bot, xan.lopez, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+, webkit-ews: commit-queue-
Patch for landing none

Andreas Kling
Reported 2013-03-10 10:50:42 PDT
SVGDocumentExtensions should use OwnPtr for pending resource maps.
Attachments
Patch (7.18 KB, patch)
2013-03-10 10:51 PDT, Andreas Kling 		andersca: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (7.44 KB, patch)
2013-03-10 13:43 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-03-10 10:51:25 PDT
Created attachment 192381 [details] Patch
Early Warning System Bot
Comment 2 2013-03-10 11:00:25 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17024104
Early Warning System Bot
Comment 3 2013-03-10 11:01:07 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/17163030
WebKit Review Bot
Comment 4 2013-03-10 11:01:47 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17124081
EFL EWS Bot
Comment 5 2013-03-10 11:05:05 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17162025
Peter Beverloo (cr-android ews)
Comment 6 2013-03-10 11:10:40 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17017862
Dirk Schulze
Comment 7 2013-03-10 11:16:59 PDT
I would like to ask you t wait till one of the SVG folks 2nd the patch before landing. thanks.
WebKit Review Bot
Comment 8 2013-03-10 11:20:09 PDT
Comment on attachment 192381 [details] Patch Attachment 192381 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17131094
Philip Rogers
Comment 9 2013-03-10 13:16:04 PDT
Except for the compile error, this looks good. I've been meaning to make the same change for some time :)
Andreas Kling
Comment 10 2013-03-10 13:43:34 PDT
Created attachment 192384 [details] Patch for landing Fixed the 0/nullptr build failure. Anders also requested that I use HashMap::AddResult instead of the awkward ValueType& foo = add().iterator->value; idiom.
WebKit Review Bot
Comment 11 2013-03-10 14:02:55 PDT
Comment on attachment 192384 [details] Patch for landing Clearing flags on attachment: 192384 Committed r145333: <http://trac.webkit.org/changeset/145333>
WebKit Review Bot
Comment 12 2013-03-10 14:03:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.