[GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

Add API to the web extensions API to get the identifier of a web page.

[Carlos Garcia Campos]

Created attachment 192375 [details]
Patch

[Carlos Garcia Campos]

Adding webkit2 owners to CC

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Benjamin Poulain]

Comment on attachment 192375 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192375&action=review

> Source/WebKit2/ChangeLog:9
> +        Add API to the web extensions API to get the identifier of a web
> +        page.

What for?

[Carlos Garcia Campos]

(In reply to comment #4)
> (From update of attachment 192375 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192375&action=review
> 
> > Source/WebKit2/ChangeLog:9
> > +        Add API to the web extensions API to get the identifier of a web
> > +        page.
> 
> What for?

To be able to match the page id of a WebKitWebView (UI process), we have webkit_web_view_get_page_id(), but it's not possible to know the id of a given WebKitWebPage (Web process)

[Carlos Garcia Campos]

Ping owners, this is trivial patch.

[Anders Carlsson]

Comment on attachment 192375 [details]
Patch

I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all?

[Carlos Garcia Campos]

(In reply to comment #7)
> (From update of attachment 192375 [details])
> I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all?

Because in our web process extension system we haven't exposed any communication API, we use the injected bundle custom messages for internal communication, but we leave the apps to use whatever they want to communicate their web process extensions with their UI process. So, we need a way to match a page from UI and Web processes.

[Carlos Garcia Campos]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 192375 [details] [details])
> > I don’t think it’s a good idea to expose identifiers in the API like this, and I think the webkit_web_view_get_page_id() function should be removed. Why is it needed at all?
> 
> Because in our web process extension system we haven't exposed any communication API, we use the injected bundle custom messages for internal communication, but we leave the apps to use whatever they want to communicate their web process extensions with their UI process. So, we need a way to match a page from UI and Web processes.

This is only available in the web extensions API for GTK+. In Epiphany we use D-Bus to communicate the web extension with the app, so that we can expose GObjects and use signals, properties, etc. We need a way to match between WebKitWebView (UI) and WebKitWebPage (Web) and we used the page id just for convenience.

[Anders Carlsson]

Comment on attachment 192375 [details]
Patch

Fair enough, r=me.

[Carlos Garcia Campos]

(In reply to comment #10)
> (From update of attachment 192375 [details])
> Fair enough, r=me.

Thank you very much :-)

[Carlos Garcia Campos]

Committed r148592: <http://trac.webkit.org/changeset/148592>