Bug 111924

Summary:

Enable platform code to implement text track menu

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, esprehn+autocc, feature-media-reviews, jer.noble, ojan.autocc, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Updated patch, removed the offensive space.	none

Description Eric Carlson 2013-03-09 11:59:17 PST

Make it possible for a port to implement the text track menu in platform code.

Comment 1 Radar WebKit Bug Importer 2013-03-09 11:59:34 PST

<rdar://problem/13386009>

Comment 2 Eric Carlson 2013-03-09 12:28:18 PST

Created attachment 192348 [details]
Proposed patch

Comment 3 WebKit Review Bot 2013-03-09 12:30:48 PST

Attachment 192348 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/html/HTMLAudioElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMediaElement.h', u'Source/WebCore/html/track/InbandTextTrack.h', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/platform/graphics/MediaPlayer.cpp', u'Source/WebCore/platform/graphics/MediaPlayer.h', u'Source/WebCore/platform/graphics/MediaPlayerPrivate.h', u'Source/WebCore/platform/graphics/PlatformTextTrack.h', u'Source/WebCore/platform/graphics/PlatformTextTrackMenu.h']" exit_code: 1
Source/WebCore/platform/graphics/PlatformTextTrackMenu.h:59:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Eric Carlson 2013-03-09 13:03:48 PST

Created attachment 192350 [details]
Updated patch, removed the offensive space.

Comment 5 WebKit Review Bot 2013-03-09 13:31:22 PST

Comment on attachment 192350 [details]
Updated patch, removed the offensive space.

Clearing flags on attachment: 192350

Committed r145322: <http://trac.webkit.org/changeset/145322>

Comment 6 WebKit Review Bot 2013-03-09 13:31:25 PST

All reviewed patches have been landed.  Closing bug.