Bug 111884

Summary: [chromium] use custom freetype on linux asan builds again
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED WONTFIX    
Severity: Normal CC: inferno, schenney, thestig, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
fix style warning / tab none

Dirk Pranke
Reported 2013-03-08 12:21:27 PST
[chromium] use custom freetype on linux asan builds again
Attachments
Patch (1.39 KB, patch)
2013-03-08 12:21 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix style warning / tab (1.39 KB, patch)
2013-03-08 12:36 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2013-03-08 12:21:59 PST
Created attachment 192269 [details] Patch
WebKit Review Bot
Comment 2 2013-03-08 12:30:45 PST
Attachment 192269 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp']" exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dirk Pranke
Comment 3 2013-03-08 12:36:54 PST
Created attachment 192272 [details] fix style warning / tab
WebKit Review Bot
Comment 4 2013-03-08 14:43:18 PST
Comment on attachment 192272 [details] fix style warning / tab Clearing flags on attachment: 192272 Committed r145272: <http://trac.webkit.org/changeset/145272>
WebKit Review Bot
Comment 5 2013-03-08 14:43:21 PST
All reviewed patches have been landed. Closing bug.
Dirk Pranke
Comment 6 2013-03-18 12:23:12 PDT
Committed r146101: <http://trac.webkit.org/changeset/146101>
Dirk Pranke
Comment 7 2013-03-18 12:24:42 PDT
Looks like there's something still wrong in the bot config, so I've reverted this, and we will disable the custom_freetype on the asan bot again for now. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/4734
Dirk Pranke
Comment 8 2013-03-19 12:20:34 PDT
Reverted r146101 for reason: re-enable custom freetype on asan Committed r146234: <http://trac.webkit.org/changeset/146234>
Note You need to log in before you can comment on or make changes to this bug.