Summary: | [WK2] Make it possible to reuse sandbox extensions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, rniwa, sam, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 111917 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-03-08 12:17:11 PST
Created attachment 192270 [details]
proposed patch
Committed <http://trac.webkit.org/changeset/145254>. It seems like this patch caused a test failure: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fdom%2FWindow%2Fredirect-with-timer.html Re-opened since this is blocked by bug 111917 Got it. The regression is caused by a bug in SandboxExtensionTracker that used to be hidden because we used to permanently leak the consumed extension in this case. Created attachment 192335 [details]
patch to land later
Updated with build fix, removed an unneeded null check, and added an assertion that would have caught this condition earlier.
Created attachment 192346 [details]
proposed patch
It turned out that it makes much more sense to fix the pre-existing bug now, as that's easier to do with the new SandboxExtension functionality.
The new patch also changes SandboxExtension to require manual balancing of consume and revoke calls. It's less error prone this way.
Comment on attachment 192346 [details] proposed patch Clearing flags on attachment: 192346 Committed r145369: <http://trac.webkit.org/changeset/145369> All reviewed patches have been landed. Closing bug. |