Bug 111844

Summary: [Curl] POST requests sometimes fail.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, peavo
Priority: P2 Keywords: Curl
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
URL: https://bugs.webkit.org/
Attachments:
Description Flags
Patch
none
Patch none

peavo
Reported 2013-03-08 04:27:59 PST
Curl adds the header 'Expect: 100-Continue' when sending a POST request. When we receive the header 'HTTP/1.1 100 Continue' we should not call ResourceHandleClient::didReceiveResponse(), as the request might be cancelled because the MIME type is empty in this case.
Attachments
Patch (1.66 KB, patch)
2013-03-08 04:38 PST, peavo 		no flags
DetailsFormatted DiffDiff
Patch (4.00 KB, patch)
2013-05-07 07:09 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-03-08 04:38:18 PST
Created attachment 192200 [details] Patch
peavo
Comment 2 2013-03-12 07:14:50 PDT
A good way to reproduce this, is to create a new bug at https://bugs.webkit.org/. When clicking the commit button after filling in the various fields, the POST request sent is always failing for me.
peavo
Comment 3 2013-05-07 07:09:17 PDT
Created attachment 200899 [details] Patch
peavo
Comment 4 2013-05-07 07:17:38 PDT
Modified the patch slightly, inspired by the blackberry port. The blackberry port also ignores http code 100 (and other info codes), see the method NetworkJob::handleNotifyStatusReceived() in WebCore\platform\network\blackberry\NetworkJob.cpp. The blackberry port also doesn't classify http code 304 (Not modified) as a redirect. I did the same thing for Curl, now the 304 code is reported as a response (ResourceHandleClient::didReceiveResponse() is called).
Brent Fulgham
Comment 5 2013-05-07 08:26:09 PDT
Comment on attachment 200899 [details] Patch Looks great!
WebKit Commit Bot
Comment 6 2013-05-07 08:52:47 PDT
Comment on attachment 200899 [details] Patch Clearing flags on attachment: 200899 Committed r149672: <http://trac.webkit.org/changeset/149672>
WebKit Commit Bot
Comment 7 2013-05-07 08:52:49 PDT
All reviewed patches have been landed. Closing bug.
peavo
Comment 8 2013-05-07 12:34:17 PDT
(In reply to comment #5) > (From update of attachment 200899 [details]) > Looks great! Thanks for the review ;)
Note You need to log in before you can comment on or make changes to this bug.