Bug 111807

Summary: Custom Elements: CustomElement constructor shouldn't share function instance
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch haraken: review+, haraken: commit-queue+

Description Hajime Morrita 2013-03-07 19:06:04 PST 
This is a facepalm bug...
A fix will come shortly.
Comment 1 Hajime Morrita 2013-03-07 19:22:32 PST 
Created attachment 192131 [details]
Patch
Comment 2 Hajime Morrita 2013-03-07 20:28:12 PST 
Committed r145175: <http://trac.webkit.org/changeset/145175>
Comment 3 Adam Barth 2013-03-08 11:40:29 PST 
Comment on attachment 192131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192131&action=review

> Source/WebCore/bindings/v8/V8AdaptorFunction.cpp:79
> -    v8::Handle<v8::Function> adaptor = v8::Handle<v8::Function>::Cast(getTemplate(isolate, worldType(isolate))->GetFunction());
> +    v8::Handle<v8::Function> adaptor = v8::Handle<v8::Function>::Cast(getTemplate(isolate, worldType(isolate))->GetFunction()->Clone());

Sorry for missing this in the review.
Comment 4 Hajime Morrita 2013-03-09 01:09:05 PST 
(In reply to comment #3)
> 
> Sorry for missing this in the review.

Well, the test should have been more comprehensive.