Bug 111761

Summary: [BlackBerry] RefCounting ParsedCookie to avoid SegFaults
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description otcheung 2013-03-07 11:53:53 PST 
Ref Count ParsedCookie.h to avoid segfaults
Comment 1 otcheung 2013-03-07 13:06:31 PST 
Created attachment 192074 [details]
Patch
Comment 2 Rob Buis 2013-03-07 13:13:17 PST 
Comment on attachment 192074 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192074&action=review

> Source/WebCore/platform/blackberry/CookieParser.cpp:193
>          return 0;

Can you use LOG_AND_RETURN here?
Comment 3 otcheung 2013-03-07 13:35:13 PST 
Created attachment 192079 [details]
Patch
Comment 4 Rob Buis 2013-03-07 13:39:16 PST 
Comment on attachment 192079 [details]
Patch

LGTM.
Comment 5 WebKit Review Bot 2013-03-07 17:33:12 PST 
Comment on attachment 192079 [details]
Patch

Clearing flags on attachment: 192079

Committed r145163: <http://trac.webkit.org/changeset/145163>
Comment 6 WebKit Review Bot 2013-03-07 17:33:15 PST 
All reviewed patches have been landed.  Closing bug.