Bug 111761

Summary: [BlackBerry] RefCounting ParsedCookie to avoid SegFaults
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: japhet, mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

otcheung
Reported 2013-03-07 11:53:53 PST
Ref Count ParsedCookie.h to avoid segfaults
Attachments
Patch (49.77 KB, patch)
2013-03-07 13:06 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (49.87 KB, patch)
2013-03-07 13:35 PST, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2013-03-07 13:06:31 PST
Created attachment 192074 [details] Patch
Rob Buis
Comment 2 2013-03-07 13:13:17 PST
Comment on attachment 192074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=192074&action=review > Source/WebCore/platform/blackberry/CookieParser.cpp:193 > return 0; Can you use LOG_AND_RETURN here?
otcheung
Comment 3 2013-03-07 13:35:13 PST
Created attachment 192079 [details] Patch
Rob Buis
Comment 4 2013-03-07 13:39:16 PST
Comment on attachment 192079 [details] Patch LGTM.
WebKit Review Bot
Comment 5 2013-03-07 17:33:12 PST
Comment on attachment 192079 [details] Patch Clearing flags on attachment: 192079 Committed r145163: <http://trac.webkit.org/changeset/145163>
WebKit Review Bot
Comment 6 2013-03-07 17:33:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.