Web Inspector: provide reasons why a layer was composited in the LayerTreeAgent

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Antoine Quint]

The reasons why a layer was composited in the first place would be very useful information to developers.

[Radar WebKit Bug Importer]

<rdar://problem/13367507>

[Antoine Quint]

Created attachment 191987 [details]
Patch

[Timothy Hatcher]

Comment on attachment 191987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191987&action=review

> Source/WebCore/inspector/Inspector.json:3708
> +                    { "name": "reasonsMask", "type": "integer", "description": "The reasons why the layer was composited." }

I don't think exposing the raw mask is safe and exposes internal WebCore data that might not be stable. There are no guarantees someone won't add an item in the middle later. Returning an array of values defined in the protocol as an enum is the safest option. That way the clients don't need internal knowledge of WebCore and everything is defined in the protocol. That would encourage anyone adding reasons in the future to also extend the protocol enums.

[Antoine Quint]

Created attachment 192038 [details]
Patch

[WebKit Review Bot]

Comment on attachment 192038 [details]
Patch

Clearing flags on attachment: 192038

Committed r145136: <http://trac.webkit.org/changeset/145136>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 192038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192038&action=review

Could you follow-up fix the typos? (My tree isn't clean)

> Source/WebCore/inspector/Inspector.json:3685
> +                "description": "An object containg the reasons why the layer was composited as properties.",

Typo: "containg" => "containing"

> Source/WebCore/inspector/Inspector.json:3693
> +                    { "name": "clipsCompositingDescendants", "type": "boolean", "optional": true, "description": "Composition due to association with an element clippng compositing descendants." },

Typo: "clippng" => "clipping"

[Antoine Quint]

(In reply to comment #7)
> (From update of attachment 192038 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192038&action=review
> 
> Could you follow-up fix the typos? (My tree isn't clean)
> 
> > Source/WebCore/inspector/Inspector.json:3685
> > +                "description": "An object containg the reasons why the layer was composited as properties.",
> 
> Typo: "containg" => "containing"
> 
> > Source/WebCore/inspector/Inspector.json:3693
> > +                    { "name": "clipsCompositingDescendants", "type": "boolean", "optional": true, "description": "Composition due to association with an element clippng compositing descendants." },
> 
> Typo: "clippng" => "clipping"

I fixed those typos in http://trac.webkit.org/changeset/145191. Thanks for spotting them Joe.