Bug 111659

Summary:

Build fix: PageAllocationAligned no longer has executable flag

Product:

WebKit

Reporter:

Adenilson Cavalcanti Silva <savagobr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, ggaren, haraken, ojan.autocc, oliver, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Use false as default value for execution parameter.	none

Adenilson Cavalcanti Silva

Reported 2013-03-06 18:34:24 PST

Compiling is failing with: /home/adenilson/apps/webkit/Webkit/Source/WTF/wtf/PageAllocationAligned.cpp:55:95: error: ‘executable’ was not declared in this scope Because it was removed in r145018. This patch fixes this issue by setting the execution parameter to default false.

Attachments
Use false as default value for execution parameter. (1.86 KB, patch) 2013-03-06 18:37 PST, Adenilson Cavalcanti Silva	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adenilson Cavalcanti Silva

Comment 1 2013-03-06 18:37:37 PST

Created attachment 191885 [details] Use false as default value for execution parameter.

Kentaro Hara

Comment 2 2013-03-06 18:48:45 PST

Comment on attachment 191885 [details] Use false as default value for execution parameter. Looks reasonable.

Ryosuke Niwa

Comment 3 2013-03-06 19:04:59 PST

Comment on attachment 191885 [details] Use false as default value for execution parameter. Clearing flags on attachment: 191885 Committed r145022: <http://trac.webkit.org/changeset/145022>

Ryosuke Niwa

Comment 4 2013-03-06 19:05:01 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.