Bug 111634

Summary:

Recalculate borders at the beginning of table layout

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Ojan Vafai <ojan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, esprehn+autocc, jchaffraix, leviw, ojan.autocc, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jchaffraix: review+

Description Ojan Vafai 2013-03-06 15:37:07 PST

Recalculate borders at the beginning of table layout

Comment 1 Ojan Vafai 2013-03-06 15:40:26 PST

Created attachment 191853 [details]
Patch

Comment 2 WebKit Review Bot 2013-03-06 15:43:01 PST

Attachment 191853 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.png', u'LayoutTests/fast/table/border-collapsing/cached-change-row-border-width-expected.txt', u'LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png', u'LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderTable.cpp']" exit_code: 1
LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Julien Chaffraix 2013-03-06 16:45:54 PST

Comment on attachment 191853 [details]
Patch

Don't forget to fix the svn:mime-type before landing.

Comment 4 Ojan Vafai 2013-03-07 11:01:41 PST

Committed r145104: <http://trac.webkit.org/changeset/145104>

Comment 5 Ojan Vafai 2013-03-07 11:09:00 PST

(In reply to comment #3)
> (From update of attachment 191853 [details])
> Don't forget to fix the svn:mime-type before landing.

Not sure what was up with this. I doubled checked my .subversion/config is correct and the commit looks correct to me. So, I'm thinking something may be wrong with the style queue + git uploaded patches.